lp:~neon/kdenetwork-filesharing/master

Branch merges

This import branch has no branches proposed for merge into it.

No branches dependent on this one.

Related source package recipes

1 recipe using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

748. By Nate Graham <email address hidden> on 2020-06-07

Merge branch 'release/20.04'

747. By l10n daemon script <email address hidden> on 2020-06-02

GIT_SILENT made messages (after extraction)

746. By l10n daemon script <email address hidden> on 2020-05-06

GIT_SILENT made messages (after extraction)

745. By Alexander Lohnau <email address hidden> on 2020-04-23

Network Filesharing: Refactor foreach and emit, smaller improvements

Summary:
Compile without emit and foreach.
The private variables inside the model are prefixed with _, because
the userList variable shadowed class definition. This should clear things up.

And some better overloads and const qualifiers.

Test Plan: Compiles

Reviewers: #dolphin, ngraham

Reviewed By: #dolphin, ngraham

Differential Revision: https://phabricator.kde.org/D29118

744. By Alexander Lohnau <email address hidden> on 2020-04-22

Network Filesharing: Fix compile warnings and trivial improvements

Summary:
Fix compile warnings:
warning: zero as null pointer constant
warning: variable ‘result’ set but not used

Additionally some improved overloads and formatting which does not
deserve a sepearte patch ;-).

Test Plan: Compiles

Reviewers: #dolphin, ngraham, mlaurent

Reviewed By: #dolphin, ngraham

Differential Revision: https://phabricator.kde.org/D29105

743. By Jonathan Marten <email address hidden> on 2020-04-21

QString::SplitBehavior enum is removed in Qt 5.15

742. By l10n daemon script <email address hidden> on 2020-04-09

GIT_SILENT made messages (after extraction)

741. By l10n daemon script <email address hidden> on 2020-04-04

SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

740. By l10n daemon script <email address hidden> on 2020-03-27

GIT_SILENT made messages (after extraction)

739. By Nate Graham <email address hidden> on 2020-03-15

Recommend rebooting after installing Samba

Summary:
After Samba is installed, very frequently it will not work correctly until the machine is
rebooted. One potential reason is when the installed package has made group membership
changes, which only take effect after a reboot.

This patch implements a reboot recommendation along with a button to reboot the machine.
Both are shown immediately after Samba has been installed.

Because some expert users may understand the technical details of what's going on, the
reboot is only recommended, not required. If the window is closed and then re-opened,
the normal Samba sharing configuration UI is displayed instead of the reboot prompt.

Added a new function rather than using a Lambda because it may be useful for additional
purposes too (e.g. https://bugs.kde.org/show_bug.cgi?id=407846)

FEATURE: 407845
FIXED-IN: 20.04.0

Test Plan:
http://s1.webmshare.com/Ry55q.webm (not uploaded to Phab due to file size limit)

1. Remove Samba
2. Go to share a folder
3. Click "Install Samba"
4. After the installation has completed, click the "Restart" button and see that the machine reboots

5. Remove Samba again
2. Go to share a folder
3. Click "Install Samba"
4. Close the window and re-open it instead of rebooting as recommended
5. See that the Samba sharing config UI is all there

Reviewers: #vdg, #frameworks, #dolphin, apol, sitter

Reviewed By: sitter

Subscribers: anthonyfieroni, sitter, bruns

Differential Revision: https://phabricator.kde.org/D21466