kmines

lp:~neon/kmines/master

Created by Philip Muškovac and last modified
Get this branch:
bzr branch lp:~neon/kmines/master

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Deprecated Projected Neon
Project:
kmines
Status:
Development

Import details

Import Status: Failed

This branch is an import of the HEAD branch of the Git repository at git://anongit.kde.org/kmines.

The import has been suspended because it failed 5 or more times in succession.

Last successful import was .

Import started on alnitak and finished taking 20 seconds — see the log
Import started on alnitak and finished taking 25 seconds — see the log
Import started on alnitak and finished taking 15 seconds — see the log
Import started on alnitak and finished taking 15 seconds — see the log

Recent revisions

1154. By Yichao Yu <email address hidden>

Fix accidental revealing of items when the game is restarted after lost from a middle click.

Summary:
When a flag is misplaced, a middle click could cause the game to lost.
Currently, if the user choose to restart the game in this case, there is a high chance
that a few pieces around the one middle clicked are revealed right after the game restarted.

The reason is that when the user restart the game in such case,
it happens within `checkLost`/`onItemRevealed` which means that the
game might not be the same one anymore after `onItemRevealed` returns
and the loop handling all neighboring pieces are now operating on the now restarted game.

The fix is to make sure the loop stops when the game is finished. Checking `m_gameOver` is
unreliable and won't work in this case since the restart of the game would have reset it.
Instead, the finished status is returned from all functions that trigger such a condition
and the information is propagated back to the caller to terminate the loop appropriately.
This also improved another unreliable use of `m_gameOver` that is currently harmless.

Debugging was possible thanks to `rr`.

Reviewers: mlaurent, yurchor, #kde_games, aacid

Reviewed By: yurchor, aacid

Subscribers: aacid, kde-games-devel

Differential Revision: https://phabricator.kde.org/D27716

1153. By Yuri Chornoivan <email address hidden>

Compile for ECM < 5.58

1152. By Laurent Montel <email address hidden>

Fix compile

1151. By Laurent Montel <email address hidden>

Use debug categories

1150. By Laurent Montel <email address hidden>

Ignore .cmake directory

1149. By Laurent Montel <email address hidden>

Move code in cpp file. Initialize value/pointer

1148. By Yuri Chornoivan <email address hidden>

Fix link: ui.html -> menus.html

1147. By l10n daemon script <email address hidden>

SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

1146. By Yuri Chornoivan <email address hidden>

Use URLs with transport encryption

1145. By l10n daemon script <email address hidden>

SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.