Merge lp:~nikwen/indicator-messages/clear-all-unescape-fix into lp:indicator-messages/15.04
Proposed by
Niklas Wenzel
Status: | Merged |
---|---|
Approved by: | Lars Karlitski |
Approved revision: | 449 |
Merged at revision: | 445 |
Proposed branch: | lp:~nikwen/indicator-messages/clear-all-unescape-fix |
Merge into: | lp:indicator-messages/15.04 |
Diff against target: |
32 lines (+18/-2) 1 file modified
src/im-application-list.c (+18/-2) |
To merge this branch: | bzr merge lp:~nikwen/indicator-messages/clear-all-unescape-fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Lars Karlitski (community) | Approve | ||
Review via email: mp+257471@code.launchpad.net |
Commit message
Unescape action names when passing them to the proxy in im_application_
Description of the change
Unescape action names when passing them to the proxy in im_application_
This fixes an issue in account-polld and ubuntu-push where no new Gmail notifications would be shown because account-polld still thinks that a "You have about %d more unread messages" notification is being shown although it has been cleared using the "Clear all" button.
To post a comment you must log in.
Good catch. Thanks for the patch!
Why are you using GArray? I'd prefer writing into a strv directly to save the extra allocation. It will also make the code much shorter:
unescaped_ source_ actions = g_new0 (gchar *, g_strv_length (source_actions) + 1); source_ actions[ i] = unescape_ action_ name (source_ actions[ i]);
for (i = 0; source_actions[i]; i++)
unescaped_
Please follow code style of the rest of the file: put space between function names and open paren and declare all variables at the beginning of a scope.