update-state-after-token-none : lp:~nteodosio/software-properties : Git : Code : Software Properties

Get this branch:: git clone -b update-state-after-token-none https://git.launchpad.net/~nteodosio/software-properties

Only Nathan Teodosio can upload to this branch. If you are Nathan Teodosio please log in for upload directions.

Branch merges

Rejected for merging into software-properties:ubuntu/master

Sebastien Bacher: Disapprove on 2023-06-06

Branch information

Name:: update-state-after-token-none

Repository:: lp:~nteodosio/software-properties

Recent commits

5c54a09... by Nathan Teodosio on 2023-02-10

Throw a more detailed error if token is not string.

https://launchpad.net/bugs/2006931 reports that
self.ua_object.Attach(token, ...) ultimately raises
TypeError: Expected a string or unicode object.

This could be caused by a invalid response from wait().
Alternatively, the user could input some random bytes
in the text field, but get_text() is supposed to return gchar*
so this is unlikely to be the source of the problem.

4a147bc... by Julian Andres Klode on 2023-05-16

releasing package software-properties version 0.99.37

c4b86dc... by Julian Andres Klode on 2023-05-16

tests: Only filter out Signed-by continuation lines

Filtering out all continuation lines would yield to false
positives if we cause bugs inserting newlines somewhere,
as continuation lines are valid in all fields.

So instead of filtering out signed-by and continuation
lines anywhere in the output in the unexpected lines, just
filter out the signed-by lines from the actual output before
comparing it.

49d2c3a... by Julian Andres Klode on 2023-05-16