Merge lp:~ohad-kammar/qbzr/configurable-colours into lp:~qbzr-dev/qbzr/trunk

This merge depends on the following merge (and indeed branched from it):
https://code.edge.launchpad.net/~ohad-kammar/qbzr/config-bugfix/+merge/1277

This is a fix to bug #280041:
https://bugs.edge.launchpad.net/qbzr/+bug/280041

Problems with this fix:
1. I am not familiar with this project's code, so you may find the fix's implementation inconsistent with the usual programming practices of the team.
2. I didn't know how to handle errors correctly, so I implemented the mechanism for detecting them, but it doesn't do anything apart from ignoring an erroneous input and using the default instead.

Thanks for your attempt. The idea is mostly correct, but implementation needs some changes.
1) function to get color values from config should be placed to util.py, preferable as QBzrConfig method.
2) ignoring error is fine, all we can do is to write corresponding message to .bzr.log using mutter() function from bzrlib.trace module
3) don't use apply() function, it's obsolete. Use QtGui.QColor(*colour_components) instead.
4) replacement_text_background should be placed at the top of the module, around colors dict definition.
5) replacement_text_background is really bad name and it's not very precise. Actually it's about interline changes highlighting.

Also we have forum/ML at google: http://groups.google.com/group/qbzr
If you wish we can discuss your code there.

Right. Good points.

I incorporated as follows:
point 1 implemented in rev. #516.
point 2 implemented in rev. #517.
point 3 implemented in rev. #518 (ignore the spelling mistake :D)
point 4 implemented in rev. #519.
point 5 implemented in rev. #520.

Cheers!
Ohad.

I know you are going to hate me :) but please change colours to colors, both in the configuration group and the code. US English is more or less standard in open source programs.

8-0 Are you serious?

Done. Code is now colourless.

It seems this was forgot :-(

I've had a look at the code - I'm happy with it, and Alexander and Lukáš comments have been addressed. So I have merge it.

Ohad: Please will you do one more thing: Please document the config options you have added in README.txt so that it is easy to find them for users.