Launchpad itself

Merge ~pelpsi/launchpad:process-death-row-lockfile-in-use-exclude-hours into launchpad:master

  1. Git
  2. lp:~pelpsi/launchpad
  3. process-death-row-lockfile-in-use-exclude-hours
  4. Merge into master
Proposed by Simone Pelosi
Status: Merged
Approved by: Simone Pelosi
Approved revision: 00af9385bc3abbbcf6529cb574f3b9c32dbb76d6
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~pelpsi/launchpad:process-death-row-lockfile-in-use-exclude-hours
Merge into: launchpad:master
Diff against target: 14 lines (+2/-2)
1 file modified
charm/launchpad-ppa-publisher/templates/crontab.j2 (+2/-2)
Reviewer Review Type Date Requested Status
Ines Almeida Approve
Colin Watson (community) Approve
Review via email: mp+457633@code.launchpad.net

Commit message

Lockfile in use by process-death-row-py `--all-derived`

We are calling `process-death-row.py --all-derived` every hour and
it shares the lockfile with `process-death-row.py -d ubuntu` that is
called every 6 hours. Thus it may happen that one of the two processes
finds the lockfile already in use.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve
Revision history for this message
Ines Almeida (ines-almeida) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charm/launchpad-ppa-publisher/templates/crontab.j2 b/charm/launchpad-ppa-publisher/templates/crontab.j2
2index f4918ed..7096ac0 100644
3--- a/charm/launchpad-ppa-publisher/templates/crontab.j2
4+++ b/charm/launchpad-ppa-publisher/templates/crontab.j2
5@@ -14,8 +14,8 @@ P3AROOT={{ ppa_archive_private_root }}
6 17,47 * * * * nice -n 15 {{ code_dir }}/cronscripts/parse-ppa-apache-access-logs.py -q --log-file=INFO:{{ logs_dir }}/parse-ppa-apache-access-logs.log
7
8 59 05 * * 0 {{ code_dir }}/cronscripts/publishing/cron.daily-ppa >> {{ logs_dir }}/cron.ppa.log 2>&1
9-1 */6 * * * nice -n 17 {{ code_dir }}/scripts/process-death-row.py -d ubuntu --ppa -q --log-file=INFO:{{ logs_dir }}/process-death-row.log
10-0 * * * * nice -n 17 {{ code_dir }}/scripts/process-death-row.py --all-derived --ppa -q --log-file=INFO:{{ logs_dir }}/derived-process-death-row.log
11+0 */6 * * * nice -n 17 {{ code_dir }}/scripts/process-death-row.py -d ubuntu --ppa -q --log-file=INFO:{{ logs_dir }}/process-death-row.log
12+0 1-5,7-11,13-17,19-23 * * * nice -n 17 {{ code_dir }}/scripts/process-death-row.py --all-derived --ppa -q --log-file=INFO:{{ logs_dir }}/derived-process-death-row.log
13 */20 * * * * nice -n 12 ionice -c 2 -n 7 {{ code_dir }}/cronscripts/ppa-generate-keys.py -q --log-file=INFO:{{ logs_dir }}/ppa-generate-keys.log
14 {% endif %}
15

Subscribers

People subscribed via source and target branches

to status/vote changes: