Merge ~pelpsi/launchpad:unembargo-buildinfo-file into launchpad:master

Proposed by Simone Pelosi
Status: Merged
Approved by: Simone Pelosi
Approved revision: fe36f46709b2c9c5abf959060d72fb1e4a6ae2a2
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~pelpsi/launchpad:unembargo-buildinfo-file
Merge into: launchpad:master
Diff against target: 38 lines (+9/-0)
2 files modified
lib/lp/soyuz/scripts/packagecopier.py (+2/-0)
lib/lp/soyuz/tests/test_packagecopyjob.py (+7/-0)
Reviewer Review Type Date Requested Status
William Grant code Approve
Review via email: mp+464838@code.launchpad.net

Commit message

Unembargo build info

Added buildinfo to unembargoed files.

LP: #2052796

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/soyuz/scripts/packagecopier.py b/lib/lp/soyuz/scripts/packagecopier.py
2index f377107..bc31af0 100644
3--- a/lib/lp/soyuz/scripts/packagecopier.py
4+++ b/lib/lp/soyuz/scripts/packagecopier.py
5@@ -87,6 +87,8 @@ def update_files_privacy(pub_record):
6 package_files.append((package_upload, "changesfile"))
7 # Unrestrict the buildlog file as necessary.
8 package_files.append((build, "log"))
9+ # Unrestrict the buildinfo file as necessary.
10+ package_files.append((build, "buildinfo"))
11 elif IPackageUploadCustom.providedBy(pub_record):
12 # Unrestrict the custom files included
13 package_files.append((pub_record, "libraryfilealias"))
14diff --git a/lib/lp/soyuz/tests/test_packagecopyjob.py b/lib/lp/soyuz/tests/test_packagecopyjob.py
15index 26fdd08..033dd6a 100644
16--- a/lib/lp/soyuz/tests/test_packagecopyjob.py
17+++ b/lib/lp/soyuz/tests/test_packagecopyjob.py
18@@ -1757,6 +1757,12 @@ class PlainPackageCopyJobTests(TestCaseWithFactory, LocalTestHelper):
19 distroseries=self.distroseries,
20 status=PackagePublishingStatus.PUBLISHED,
21 )
22+ [build] = spph.getBuilds()
23+ build.addBuildInfo(
24+ self.factory.makeLibraryFileAlias(
25+ filename="build_info.info", restricted=True
26+ )
27+ )
28 spr = spph.sourcepackagerelease
29 for source_file in spr.files:
30 self.assertTrue(source_file.libraryfile.restricted)
31@@ -1837,6 +1843,7 @@ class PlainPackageCopyJobTests(TestCaseWithFactory, LocalTestHelper):
32 copied_build = copied_binary.binarypackagerelease.build
33 self.assertFalse(copied_build.upload_changesfile.restricted)
34 self.assertFalse(copied_build.log.restricted)
35+ self.assertFalse(copied_build.buildinfo.restricted)
36
37 def test_copy_custom_upload_files(self):
38 # Copyable custom upload files are queued for republication when

Subscribers

People subscribed via source and target branches

to status/vote changes: