Launchpad itself

Merge ~pelpsi/launchpad:add-fetch-service-certificate-to-secrets into launchpad:master

  1. Git
  2. lp:~pelpsi/launchpad
  3. add-fetch-service-certificate-to-secrets
  4. Merge into master
Proposed by Simone Pelosi
Status: Merged
Approved by: Simone Pelosi
Approved revision: 71ecbbdd3b59c545ca3f89e59fce87108f927221
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~pelpsi/launchpad:add-fetch-service-certificate-to-secrets
Merge into: launchpad:master
Diff against target: 9 lines (+1/-0)
1 file modified
charm/launchpad-buildd-manager/templates/launchpad-buildd-manager-secrets-lazr.conf (+1/-0)
Reviewer Review Type Date Requested Status
Ines Almeida Approve
Guruprasad Approve
Review via email: mp+464850@code.launchpad.net

Commit message

Add fetch_service_mitm_certificate to secrets

To post a comment you must log in.
Revision history for this message
Guruprasad (lgp171188) wrote :

LGTM 👍 Please wait till I merge my charm upgrade changes and deploy them to production before you merge this MP, since you only want to test these changes on qastaging first.

review: Approve
Revision history for this message
Ines Almeida (ines-almeida) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charm/launchpad-buildd-manager/templates/launchpad-buildd-manager-secrets-lazr.conf b/charm/launchpad-buildd-manager/templates/launchpad-buildd-manager-secrets-lazr.conf
2index 7637fcb..9b306c1 100644
3--- a/charm/launchpad-buildd-manager/templates/launchpad-buildd-manager-secrets-lazr.conf
4+++ b/charm/launchpad-buildd-manager/templates/launchpad-buildd-manager-secrets-lazr.conf
5@@ -16,3 +16,4 @@
6 [builddmaster]
7 {{- opt("builder_proxy_auth_api_admin_secret", builder_proxy_auth_api_admin_secret) }}
8 {{- opt("fetch_service_control_admin_secret", fetch_service_control_admin_secret) }}
9+{{- opt("fetch_service_mitm_certificate", fetch_service_mitm_certificate) }}

Subscribers

People subscribed via source and target branches

to status/vote changes: