~pelpsi/launchpad:send-bug-notifications-opsees-list-index-out-of-range

Branch merges

Propose for merging

Merged into launchpad:master

Ines Almeida: Approve on 2023-06-22

Diff: 104 lines (+66/-5)

2 files modified

lib/lp/bugs/model/bugnotification.py (+10/-5)
lib/lp/bugs/scripts/tests/test_bugnotification.py (+56/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

ca69e01... by Simone Pelosi on 2023-06-21

Fixed list index out of range

filters_by_person[x] set was replaced every iteration.
Now it's updated using the "update" set function.

LP: #2023938

	docs:0 (build)
	lint:0 (build)
	mypy:0 (build)

1 → 3 of 3 results

First • Previous • Next • Last

1a64fbf... by Colin Watson on 2023-06-19

charm: Deconfigure nrpe when service is deconfigured

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/444970

213bddf... by Colin Watson on 2023-06-19

charm: Deconfigure nrpe when service is deconfigured

Otherwise changes to the Nagios check that we write out aren't written
out when upgrading the charm.

bd2e7e0... by Colin Watson on 2023-06-19

charm/launchpad-appserver: Use /_status/check as health check

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/444939

d569160... by Colin Watson on 2023-06-16

charm/launchpad-appserver: Use /_status/check as health check

This is more lightweight than checking the front page, but it still
checks that the appserver has a database connection.

6b25c76... by Colin Watson on 2023-06-16

Refactor field declarations for snap build channels

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/411626

6a646a0... by Guruprasad on 2023-06-16

Use the teammembership dbuser in the check-teamparticipation.py script

All similar cron scripts have an explicit database user and only this
script doesn't and falls back to the default user defined in the
connection string. With this change, we have an explicit assignment.

Merged from https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/444926

489330b... by Colin Watson on 2023-06-16

Fix database initialization in charmed deployments

Merged from https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/444933

4b5fe2a... by Colin Watson on 2023-06-16

Fix database initialization in charmed deployments

In charmed deployments, `launchpad-admin` is typically related to
`postgresql`, which causes the `postgresql` charm to automatically
create an empty `session_dev` database. This confuses the `create`
target in `database/schema/Makefile` into assuming that the
`session_dev` database has already been initialized and not doing so
again.

I couldn't find any record in git history of why we bother to perform
this check for `session_dev` when we don't do so for any of the other
databases. I think it makes more sense to assume that if you're running
the `create` target then you mean to actually create all the databases,
so this commit brings the handling of `session_dev` into line with all
the other databases.

b4982a2... by Guruprasad on 2023-06-16

Use the teammembership dbuser in the check-teamparticipation.py script

All similar cron scripts have an explicit database user and only this
script doesn't and falls back to the default user defined in the
connection string. With this change, we have an explicit assignment.