Merge lp:~peter.waller/widelands/toggle-fullscreen-rewrite into lp:widelands
Proposed by
Peter Waller
Status: | Rejected |
---|---|
Rejected by: | SirVer |
Proposed branch: | lp:~peter.waller/widelands/toggle-fullscreen-rewrite |
Merge into: | lp:widelands |
Diff against target: |
93 lines (+33/-18) 2 files modified
src/graphic/graphic.cc (+29/-18) src/graphic/graphic.h (+4/-0) |
To merge this branch: | bzr merge lp:~peter.waller/widelands/toggle-fullscreen-rewrite |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Widelands Developers | Pending | ||
Review via email: mp+103558@code.launchpad.net |
Description of the change
Hi. I'm _certain_ there are things wrong with this, but it appears to work and not leak memory, so I thought I would propose merging to have a review.
I was expecting there to be problems due to some relationship between Pictures and the m_sdl_screen, but I haven't seen them.
Tested: switching hundreds of times repeatedly (removing the keydown check so that the 'f' key toggles as fast as possible), no visible memory increase.
To post a comment you must log in.
Unmerged revisions
- 6358. By Peter Waller
-
Experimental: Remove use of SDL_WM_
ToggleFullScree n
Unfortunately, this no longer works. I feel this merge request somehow slipped by and noone did properly look at it. I am very sorry for this Peter!
Setting to rejected for now.