Launchpad itself

Merge ~petermakowski/launchpad:set-font-color-#000 into launchpad:master

  1. Git
  2. lp:~petermakowski/launchpad
  3. set-font-color-#000
  4. Merge into master
Proposed by Peter Makowski
Status: Merged
Approved by: Ines Almeida
Approved revision: 45e2d69bfbc181899eb650fb3b7533cd497e051b
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~petermakowski/launchpad:set-font-color-#000
Merge into: launchpad:master
Diff against target: 13 lines (+1/-1)
1 file modified
lib/canonical/launchpad/icing/css/base.scss (+1/-1)
Reviewer Review Type Date Requested Status
Ines Almeida Approve
Review via email: mp+444621@code.launchpad.net

Commit message

set body font color to #000

Description of the change

set body font color to #000 as suggested by Vanilla framework team.

This increases colour contrast and is likely to improve font rendering that's been reported to cause issues for some users.

## Before
https://share.cleanshot.com/CZRm3XQB

## After
https://share.cleanshot.com/xCf8bMVz

To post a comment you must log in.
Revision history for this message
Ines Almeida (ines-almeida) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/canonical/launchpad/icing/css/base.scss b/lib/canonical/launchpad/icing/css/base.scss
2index a28ec5d..970fce5 100644
3--- a/lib/canonical/launchpad/icing/css/base.scss
4+++ b/lib/canonical/launchpad/icing/css/base.scss
5@@ -6,7 +6,7 @@ body {
6 sans-serif;
7 font-size: 0.8rem;
8 line-height: 1.2rem;
9- color: #333;
10+ color: #000;
11
12 &.private, &.public {
13 /* It must be obvious to the user that the context is private */

Subscribers

People subscribed via source and target branches

to status/vote changes: