dialer-app

Merge lp:~phablet-team/dialer-app/fix_duplicated_calls into lp:dialer-app/staging

  1. fix_duplicated_calls
  2. Merge into staging
Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Bill Filler
Approved revision: 562
Merged at revision: 562
Proposed branch: lp:~phablet-team/dialer-app/fix_duplicated_calls
Merge into: lp:dialer-app/staging
Diff against target: 14 lines (+5/-0)
1 file modified
src/qml/DialerPage/DialerPage.qml (+5/-0)
To merge this branch: bzr merge lp:~phablet-team/dialer-app/fix_duplicated_calls
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann (community) Approve
Review via email: mp+322006@code.launchpad.net

Commit message

Avoid placing multiple calls when pressing enter by removing the focus of the view

Description of the change

Avoid placing multiple calls when pressing enter by removing the focus of the view

To post a comment you must log in.
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/DialerPage/DialerPage.qml'
2--- src/qml/DialerPage/DialerPage.qml 2017-03-22 17:46:30 +0000
3+++ src/qml/DialerPage/DialerPage.qml 2017-04-05 14:27:12 +0000
4@@ -193,6 +193,11 @@
5 return
6 }
7
8+ // in case Enter is pressed, remove focus from the view to prevent multiple calls to get placed
9+ if (event.key == Qt.Key_Return || event.key == Qt.Key_Enter) {
10+ page.focus = false;
11+ }
12+
13 keypad.keyPressed(event.key, event.text)
14 }
15

Subscribers

People subscribed via source and target branches

to all changes: