dialer-app

Merge lp:~phablet-team/dialer-app/use_union_filter into lp:dialer-app/staging

  1. use_union_filter
  2. Merge into staging
Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 561
Merged at revision: 560
Proposed branch: lp:~phablet-team/dialer-app/use_union_filter
Merge into: lp:dialer-app/staging
Diff against target: 22 lines (+10/-1)
1 file modified
src/qml/HistoryPage/HistoryPage.qml (+10/-1)
To merge this branch: bzr merge lp:~phablet-team/dialer-app/use_union_filter
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
Review via email: mp+321100@code.launchpad.net

Commit message

Use union filter to force history model query the server.

Description of the change

Use union filter to force history model query the server.

To post a comment you must log in.
lp:~phablet-team/dialer-app/use_union_filter updated
561. By Tiago Salem Herrmann

add FIXME

Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/HistoryPage/HistoryPage.qml'
2--- src/qml/HistoryPage/HistoryPage.qml 2017-03-22 17:08:12 +0000
3+++ src/qml/HistoryPage/HistoryPage.qml 2017-03-27 17:44:53 +0000
4@@ -147,8 +147,17 @@
5 }
6 }
7
8- HistoryFilter {
9+ // FIXME: this is a workaround to force the model perform the query
10+ HistoryUnionFilter {
11 id: emptyFilter
12+ HistoryFilter {
13+ filterProperty: "missed"
14+ filterValue: true
15+ }
16+ HistoryFilter {
17+ filterProperty: "missed"
18+ filterValue: false
19+ }
20 }
21
22 HistoryFilter {

Subscribers

People subscribed via source and target branches

to all changes: