history-service

Merge lp:~phablet-team/history-service/fix_async_call into lp:history-service/staging

  1. fix_async_call
  2. Merge into staging
Proposed by Gustavo Pichorim Boiko
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 265
Merged at revision: 265
Proposed branch: lp:~phablet-team/history-service/fix_async_call
Merge into: lp:history-service/staging
Diff against target: 11 lines (+1/-0)
1 file modified
src/managerdbus.cpp (+1/-0)
To merge this branch: bzr merge lp:~phablet-team/history-service/fix_async_call
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann (community) Approve
Review via email: mp+320743@code.launchpad.net

Commit message

Fix return value of a function that is now asynchronous

Description of the change

Fix return value of a function that is now asynchronous

To post a comment you must log in.
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

good catch.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/managerdbus.cpp'
2--- src/managerdbus.cpp 2017-03-08 21:27:38 +0000
3+++ src/managerdbus.cpp 2017-03-23 01:20:10 +0000
4@@ -161,6 +161,7 @@
5 }
6
7 mInterface.asyncCall("RemoveEvents", QVariant::fromValue(eventMap));
8+ return true;
9 }
10
11 Thread ManagerDBus::getSingleThread(EventType type, const QString &accountId, const QString &threadId, const QVariantMap &properties)

Subscribers

People subscribed via source and target branches

to all changes: