messaging-app

Merge lp:~phablet-team/messaging-app/close_channels_on_remove into lp:messaging-app/staging

Proposed by Tiago Salem Herrmann on 2017-02-02

Status:	Merged
Approved by:	Gustavo Pichorim Boiko on 2017-03-22
Approved revision:	647
Merged at revision:	655
Proposed branch:	lp:~phablet-team/messaging-app/close_channels_on_remove
Merge into:	lp:messaging-app/staging
Prerequisite:	lp:~phablet-team/messaging-app/irc-style
Diff against target:	11 lines (+1/-0) 1 file modified src/qml/messaging-app.qml (+1/-0)
To merge this branch:	bzr merge lp:~phablet-team/messaging-app/close_channels_on_remove
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Gustavo Pichorim Boiko (community)		2017-02-02	Approve on 2017-03-22
Review via email: mp+316267@code.launchpad.net

Close channels when threads are removed.

Close channels when threads are removed.

Revision history for this message

Gustavo Pichorim Boiko (boiko) wrote on 2017-03-22:

Looks good!

review: Approve

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

People subscribed via source and target branches

to all changes:

1	=== modified file 'src/qml/messaging-app.qml'
2	--- src/qml/messaging-app.qml 2017-03-08 22:07:14 +0000
3	+++ src/qml/messaging-app.qml 2017-03-08 22:07:14 +0000
4	@@ -115,6 +115,7 @@
5	// and acknowledge all messages for the threads to be removed
6	var properties = {'accountId': thread.accountId, 'threadId': thread.threadId,'participantIds': participants, 'chatType': thread.chatType}
7	chatManager.acknowledgeAllMessages(properties)
8	+ chatManager.leaveRoom(properties, "")
9	}
10	// at last remove the threads
11	threadModel.removeThreads(threads);