Launchpad itself

Merge ~philroche/launchpad:feature/dont-expire-security-proposed-ppa into launchpad:master

  1. Git
  2. lp:~philroche/launchpad
  3. feature/dont-expire-security-proposed-ppa
  4. Merge into master
Proposed by Philip Roche
Status: Merged
Approved by: Jürgen Gmach
Approved revision: 92bdacea8bef2a8aff1c91c08b4cfdd3aede84e7
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~philroche/launchpad:feature/dont-expire-security-proposed-ppa
Merge into: launchpad:master
Diff against target: 11 lines (+1/-0)
1 file modified
lib/lp/soyuz/scripts/expire_archive_files.py (+1/-0)
Reviewer Review Type Date Requested Status
Jürgen Gmach Approve
Review via email: mp+460937@code.launchpad.net

Commit message

feat: Don't expire Ubuntu Security Proposed PPA

This archive is used for many security builds and to ensure further support for our
reproducible builds efforts the packages in this PPA should always be available and should not expire.

We should keep their history in the same way we do with the main archive.

To post a comment you must log in.
Revision history for this message
Jürgen Gmach (jugmac00) wrote :

Makes sense.

I think I would fancy a unit test ensuring we cannot delete this line without a failing test, but I have noticed that there is no test for the other entries, and the other additions did not come with any test.

If we make up our minds to insist on tests, that would be on the Launchpad team to do so.

Thanks for your contribution!

review: Approve
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

maybe this should be converted to "retention_policy" setting on the archive object, and then have ability to set it and change it as an admin......

but also this list has not been growing that much or that fast.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/lp/soyuz/scripts/expire_archive_files.py b/lib/lp/soyuz/scripts/expire_archive_files.py
2index ed578dc..55fb8ce 100755
3--- a/lib/lp/soyuz/scripts/expire_archive_files.py
4+++ b/lib/lp/soyuz/scripts/expire_archive_files.py
5@@ -50,6 +50,7 @@ ubuntu-esm/esm-apps-updates
6 ubuntu-esm/esm-infra-security
7 ubuntu-esm/esm-infra-updates
8 ubuntu-mobile
9+ubuntu-security-proposed/ppa
10 wheelbarrow
11 """.split()
12

Subscribers

People subscribed via source and target branches

to status/vote changes: