GNU Mailman

Merge lp:~prakash09/mailman/test into lp:mailman

  1. test
  2. Merge into 3.0
Proposed by Prakash Kumar
Status: Rejected
Rejected by: Barry Warsaw
Proposed branch: lp:~prakash09/mailman/test
Merge into: lp:mailman
Diff against target: 18 lines (+6/-0)
1 file modified
src/mailman/app/tests/test_registration.py (+6/-0)
To merge this branch: bzr merge lp:~prakash09/mailman/test
Reviewer Review Type Date Requested Status
Barry Warsaw Needs Fixing
Review via email: mp+253150@code.launchpad.net

Description of the change

Test added for registration of odd email id. It is the test for the bug https://bugs.launchpad.net/mailman/+bug/266288. Test is added in the 'src/mailman/app/tests/test_registration.py' file.

To post a comment you must log in.
lp:~prakash09/mailman/test updated
7302. By Prakash Kumar

Path for starting mailman is corrected

7303. By Prakash Kumar

test for odd email id registration is added

Revision history for this message
Barry Warsaw (barry) wrote :

Are you proposing a fix or other change to the code, or just adding a test? All I see is the test.

review: Needs Fixing

Unmerged revisions

7303. By Prakash Kumar

test for odd email id registration is added

7302. By Prakash Kumar

Path for starting mailman is corrected

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/mailman/app/tests/test_registration.py'
2--- src/mailman/app/tests/test_registration.py 2015-01-05 01:22:39 +0000
3+++ src/mailman/app/tests/test_registration.py 2015-03-17 04:46:34 +0000
4@@ -59,6 +59,12 @@
5 self.registrar.register, self.mlist,
6 '<script>@example.com')
7
8+ #test for this(https://bugs.launchpad.net/mailman/+bug/266288) bug
9+ def test_odd_address_allowed(self):
10+ self.assertRaises(InvalidEmailAddressError,
11+ self.registrar.register,self.mlist,
12+ '---abcd---@xyz.org')
13+
14 def test_ascii_only(self):
15 self.assertRaises(InvalidEmailAddressError,
16 self.registrar.register, self.mlist,
17
18=== modified file 'src/mailman/docs/START.rst'