lp:~rcj/vmbuilder/mfdiff_fixups

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~ubuntu-on-ec2/vmbuilder/mfdiff at revision 19

Francis Ginther (community): Approve on 2017-06-28

Dan Watkins (community): Approve on 2017-06-27

Diff: 903 lines (+581/-281)

2 files modified

README (+9/-10)
mfdiff (+572/-271)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

49. By Robert C Jennings on 2017-06-27

Strip architecture from binary when searching cache

48. By Robert C Jennings on 2017-06-27

Copy rather than rename changelog files

We had been renaming changelog temporary files to place them in
the cache directory if we were successful. A prior commit
(r44 Use the current directory for temp changelog files) was meant
to solve a failure to rename between file systems; this fixed the
default usage where the apt cache directory is created in the current
directory. This fix is insufficient if the user uses the --cache_d
commandline argument to specify a path on a filesystem different
from that filesystem for the current directory. This patch changes
the rename to a copy operation to completely resolve this issue.

47. By Robert C Jennings on 2017-06-27

Force output to UTF-8 at all times

We want to output UTF-8 at all times to preserve Unicode characters
in the changelog blocks. For Python 2 we will wrap sys.stdout with
an instance of StreamWriter with our preferred coding. Python3 requires
no changes.

When writing output to the terminal we get the encoding of the
terminal (utf-8 these days). When we redirect or pipe the output of
the program it is generally not possible to know what the input
encoding of the receiving program is, the encoding when redirecting
to a file will be None (Python 2.7) or UTF-8 (Python 3)

$ python2.7 -c "import sys; print sys.stdout.encoding" | cat
None

$ python3.4 -c "import sys; print(sys.stdout.encoding)" | cat
UTF-8

Source:
https://wiki.python.org/moin/PrintFails#print.2C_write_and_Unicode_in_pre-3.0_Python

46. By Robert C Jennings on 2017-06-27

Output utf-8 rather than ascii

45. By Robert C Jennings on 2017-06-27

Change exception rendering for python3 compatibility

44. By Robert C Jennings on 2017-06-27

Use the current directory for temp changelog files

43. By Robert C Jennings on 2017-06-27

Improve variable naming for changelog_url (was clog_url)

42. By Robert C Jennings on 2017-06-26

Support non-x86 architectures

41. By Robert C Jennings on 2017-06-26

Fix usage text to correct option order

40. By Robert C Jennings on 2017-06-26

Eliminate traceback if binary package has been renamed (no longer in apt cache)