Merge ~renanrodrigo/update-notifier:respect-phasing-focal into update-notifier:focal
Proposed by
Renan Rodrigo
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 464f05a7f8721879e6c2ac7f254aac2ff9542e13 | ||||
Proposed branch: | ~renanrodrigo/update-notifier:respect-phasing-focal | ||||
Merge into: | update-notifier:focal | ||||
Diff against target: |
71 lines (+32/-6) 2 files modified
data/apt_check.py (+26/-6) debian/changelog (+6/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Athos Ribeiro | Approve | ||
Review via email: mp+438011@code.launchpad.net |
Description of the change
isolate creation of the esm apt cache in apt-check
create a separate function to configure apt_pkg, create the esm cache
and reinitialize the default configuration
To post a comment you must log in.
The code review was performed for the development branch at https:/ /code.launchpad .net/~renanrodr igo/update- notifier/ +git/update- notifier/ +merge/ 438009.
The range diff is sane compared to the development changes. The only diff is the version/target series in the changelog.
The package builds fine and the DEP8 test suite is passing.
LGTM
Uploaded
Uploading to ubuntu (via ftp to upload.ubuntu.com): notifier_ 3.192.30. 17.dsc: done. notifier_ 3.192.30. 17.tar. xz: done. notifier_ 3.192.30. 17_source. buildinfo: done. notifier_ 3.192.30. 17_source. changes: done.
Uploading update-
Uploading update-
Uploading update-
Uploading update-
Successfully uploaded packages.