lp:~ricardokirkner/rnr-server/submit-review-with-macaroons

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:rnr-server at revision 317

Fabián Ezequiel Gallina (community): Approve on 2016-05-17

Diff: 982 lines (+577/-37)

13 files modified

requirements-devel.txt (+1/-0)
requirements.txt (+1/-0)
src/clickreviews/forms.py (+2/-2)
src/core/api/auth/__init__.py (+2/-0)
src/core/api/auth/macaroon.py (+82/-0)
src/core/api/auth/sso.py (+2/-2)
src/core/tests/doubles.py (+119/-0)
src/core/tests/helpers.py (+42/-0)
src/core/tests/test_api_auth.py (+121/-2)
src/core/tests/test_utilities.py (+123/-15)
src/core/utilities.py (+40/-6)
src/reviewsapp/api/urls.py (+4/-3)
src/reviewsapp/tests/test_handlers.py (+38/-7)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

327. By Ricardo Kirkner on 2016-05-17

minor changes per review

326. By Ricardo Kirkner on 2016-05-17

updated code based on changes on the verify_acl api

325. By Ricardo Kirkner on 2016-05-17

unify code into update_or_create_user_from_sso

324. By Ricardo Kirkner on 2016-05-17

remove unnecessary decoration

323. By Ricardo Kirkner on 2016-05-16

switch api from GET to POST

322. By Ricardo Kirkner on 2016-05-16

improvements per review

321. By Ricardo Kirkner on 2016-05-16

support submitting reviews using macaroon based authentication

320. By Ricardo Kirkner on 2016-05-16

improve authentication based on macaroons

- updated verify_acl call to reflect changes in api
- get or create user from retrieved account data
- inject user into request for consistency with other auth handlers

319. By Ricardo Kirkner on 2016-05-13

added macaroon based authentication support for resources

318. By Ricardo Kirkner on 2016-05-13

verify request is properly authenticated by asking SCA about it

ensure request has a valid set of macaroons in the authorization header and that
the root macaroon contains permission for 'package_access'