Merge lp:~rockstar/launchpad/cancel-rescore-redux into lp:launchpad
Proposed by
Paul Hummer
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Curtis Hovey | ||||||||
Approved revision: | no longer in the source branch. | ||||||||
Merged at revision: | 11230 | ||||||||
Proposed branch: | lp:~rockstar/launchpad/cancel-rescore-redux | ||||||||
Merge into: | lp:launchpad | ||||||||
Diff against target: |
54 lines (+10/-2) 2 files modified
lib/lp/code/browser/sourcepackagerecipebuild.py (+8/-2) lib/lp/code/browser/tests/test_sourcepackagerecipebuild.py (+2/-0) |
||||||||
To merge this branch: | bzr merge lp:~rockstar/launchpad/cancel-rescore-redux | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | Approve | ||
Review via email: mp+30856@code.launchpad.net |
Description of the change
While doing some QA, I noticed that our new Cancel and Rescore actions aren't liberal enough in when they allow us to get to them. Basically, I was checking for a buildqueue, when sometimes it can be in a non-final state and not have a buildqueue (although this specific case we found might also be a bug, not sure yet).
This branch just fixes those two issues.
To post a comment you must log in.
Nice fix.