Merge lp:~rockstar/launchpad/create-recipe-error-messages into lp:launchpad
Proposed by
Paul Hummer
Status: | Merged |
---|---|
Approved by: | Paul Hummer |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11154 |
Proposed branch: | lp:~rockstar/launchpad/create-recipe-error-messages |
Merge into: | lp:launchpad |
Diff against target: |
46 lines (+17/-4) 2 files modified
lib/lp/code/browser/sourcepackagerecipe.py (+3/-2) lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+14/-2) |
To merge this branch: | bzr merge lp:~rockstar/launchpad/create-recipe-error-messages |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jonathan Lange (community) | code | Approve | |
Review via email: mp+30253@code.launchpad.net |
Description of the change
This branch is a very small fix to pass the bzr-builder exception on to the user when creating a source package recipe. It's bug #604725. I had to change the test a bit so that I could actually construct a real recipe. In fact, since I was sitting next to thumper at the time he found this bug (we knew it existed, but hadn't encountered it yet), I made the test very specific to his exact use case.
I _think_ this test will need to be changed when we update bzr-builder next, because James made some other changes to the exceptions in bzr-builder recently.
To post a comment you must log in.
On Mon, Jul 19, 2010 at 12:41 PM, Paul Hummer <email address hidden> wrote: /bugs.launchpad .net/bugs/ 604725
> Paul Hummer has proposed merging lp:~rockstar/launchpad/create-recipe-error-messages into lp:launchpad/devel.
>
> Requested reviews:
> Jonathan Lange (jml): code
> Related bugs:
> #604725 Parse errors creating recipe don't show the exception message
> https:/
>
>
> This branch is a very small fix to pass the bzr-builder exception on to the user when creating a source package recipe. It's bug #604725. I had to change the test a bit so that I could actually construct a real recipe. In fact, since I was sitting next to thumper at the time he found this bug (we knew it existed, but hadn't encountered it yet), I made the test very specific to his exact use case.
Hey Paul,
This branch looks great. Only one question:
... code/browser/ tests/test_ sourcepackagere cipe.py' code/browser/ tests/test_ sourcepackagere cipe.py 2010-07-13 10:28:38 +0000 code/browser/ tests/test_ sourcepackagere cipe.py 2010-07-19 10:41:11 +0000 recipe_ bad_text( self): pe('Foo bar baz') makeProduct( 'Ratatouille' ) makeBranch( makeBranch(
> === modified file 'lib/lp/
> --- lib/lp/
> +++ lib/lp/
> @@ -192,10 +192,26 @@
> def test_create_
> # If a user tries to create source package recipe with bad text, they
> # should get an error.
> - browser = self.createReci
> + product = self.factory.
> + name='ratatouille', displayname=
> + branch = self.factory.
> + owner=self.chef, product=product, name='veggies')
> + package_branch = self.factory.
> + owner=self.chef, product=product, name='packaging')
> +
Why is the common product, branch name and branch owner relevant?
Why not: makeBranch( ) makeBranch( )
branch = self.factory.
package_branch = self.factory.
?
jml