Merge lp:~rockstar/launchpad/edit-recipe-name into lp:launchpad
Proposed by
Paul Hummer
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 10974 | ||||
Proposed branch: | lp:~rockstar/launchpad/edit-recipe-name | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
160 lines (+109/-10) 2 files modified
lib/lp/code/browser/sourcepackagerecipe.py (+26/-9) lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+83/-1) |
||||
To merge this branch: | bzr merge lp:~rockstar/launchpad/edit-recipe-name | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Leonard Richardson (community) | code | Approve | |
Review via email: mp+27072@code.launchpad.net |
Description of the change
This branch fixes bug #591271. The validation method checks to see if a recipe exists with the same owner and the same name. This was fine for new recipes, but broke editing recipes. So I had it check to see if there was an existing recipe AND see if that existing recipe was the current one.
To post a comment you must log in.
I don't see a test case for trying to rename an existing recipe to the name of another existing recipe. Other than that, this looks good.