Launchpad itself

Merge lp:~rockstar/launchpad/person-recipe-listings into lp:launchpad

  1. person-recipe-listings
  2. Merge into devel
Proposed by Paul Hummer
Status: Merged
Approved by: Māris Fogels
Approved revision: no longer in the source branch.
Merged at revision: 11304
Proposed branch: lp:~rockstar/launchpad/person-recipe-listings
Merge into: lp:launchpad
Diff against target: 52 lines (+8/-7)
3 files modified
lib/lp/registry/browser/person.py (+2/-2)
lib/lp/registry/templates/person-portlet-contact-details.pt (+0/-5)
lib/lp/soyuz/templates/person-portlet-ppas.pt (+6/-0)
To merge this branch: bzr merge lp:~rockstar/launchpad/person-recipe-listings
Reviewer Review Type Date Requested Status
Māris Fogels (community) code Approve
Review via email: mp+31688@code.launchpad.net

Description of the change

This branch is really easy. It moves a person's recipe links to be part of the ppa portlet instead of where it is now. It fixes bug #592937.

To post a comment you must log in.
Revision history for this message
Māris Fogels (mars) wrote :

Hi Paul,

This looks good to me. As noted on IRC, the 'earma' change is a typo that slipped by submission. I wouldn't be surprised if a portlet view test caught this though.

r=mars

Maris

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/registry/browser/person.py'
2--- lib/lp/registry/browser/person.py 2010-08-03 03:43:33 +0000
3+++ lib/lp/registry/browser/person.py 2010-08-05 16:18:23 +0000
4@@ -1264,7 +1264,7 @@
5 return Link(target, text, icon=icon, enabled=enabled)
6
7
8-class TeamOverviewMenu(ApplicationMenu, TeamMenuMixin):
9+class TeamOverviewMenu(ApplicationMenu, TeamMenuMixin, HasRecipesMenuMixin):
10
11 usedfor = ITeam
12 facet = 'overview'
13@@ -1275,7 +1275,7 @@
14 'editlanguages', 'map', 'polls',
15 'add_poll', 'join', 'leave', 'add_my_teams',
16 'reassign', 'projects', 'activate_ppa', 'maintained', 'ppa',
17- 'related_software_summary']
18+ 'related_software_summary', 'view_recipes']
19
20
21 class TeamOverviewNavigationMenu(NavigationMenu, TeamMenuMixin):
22
23=== modified file 'lib/lp/registry/templates/person-portlet-contact-details.pt'
24--- lib/lp/registry/templates/person-portlet-contact-details.pt 2010-06-24 14:10:56 +0000
25+++ lib/lp/registry/templates/person-portlet-contact-details.pt 2010-08-05 16:18:23 +0000
26@@ -195,11 +195,6 @@
27 </dd>
28 </dl>
29 </div>
30- <div tal:define="link context/menu:overview/view_recipes"
31- tal:condition="link/enabled">
32- <a tal:replace="structure link/fmt:link" />
33- </div>
34-
35
36 </div>
37
38
39=== modified file 'lib/lp/soyuz/templates/person-portlet-ppas.pt'
40--- lib/lp/soyuz/templates/person-portlet-ppas.pt 2010-04-19 03:36:55 +0000
41+++ lib/lp/soyuz/templates/person-portlet-ppas.pt 2010-08-05 16:18:23 +0000
42@@ -21,4 +21,10 @@
43
44 </ul>
45 </div>
46+ <div tal:define="link context/menu:overview/view_recipes"
47+ tal:condition="link/enabled">
48+ <a tal:replace="structure link/fmt:link" />
49+ </div>
50+
51+
52 </tal:root>