Merge lp:~rockstar/launchpad/recipe-security into lp:launchpad
Proposed by
Paul Hummer
Status: | Merged |
---|---|
Approved by: | Robert Collins |
Approved revision: | no longer in the source branch. |
Merged at revision: | 11194 |
Proposed branch: | lp:~rockstar/launchpad/recipe-security |
Merge into: | lp:launchpad |
Diff against target: |
205 lines (+32/-9) 5 files modified
lib/lp/code/browser/sourcepackagerecipe.py (+2/-0) lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+10/-3) lib/lp/code/configure.zcml (+5/-4) lib/lp/code/model/tests/test_sourcepackagerecipe.py (+12/-1) lib/lp/registry/model/person.py (+3/-1) |
To merge this branch: | bzr merge lp:~rockstar/launchpad/recipe-security |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Collins (community) | Approve | ||
Björn Tillenius (community) | Needs Information | ||
Jelmer Vernooij (community) | code | Needs Information | |
Review via email: mp+28410@code.launchpad.net |
Description of the change
This branch fixes bug #593221 - We changed the recipe permission to be launchpad.View. This had adverse affects because of the delegation from SourcePackageRecipe to SourcePackageRe
As reviewer, please make sure all the places I've opted to do transaction.commit are sane. Ask me why I put them where I put them, etc.
To post a comment you must log in.
Sorry - local email fail, so retrying here using the web UI.
The places where you transaction. commit( ) all make sense to me, right after you create SourcePackageRe cipes. They don't all appear to be necessary though (tests still pass after I remove them), presumably because we do commits in other places (that we shouldn't rely on) as well?
Another thought; would it perhaps be possible to use Store.of().flush() rather than transaction. commit( )? It seems to work in at least some of the cases.