Ubuntu One Client

Merge lp:~rodrigo-moya/ubuntuone-client/dont-connect-when-ready into lp:ubuntuone-client

  1. dont-connect-when-ready
  2. Merge into trunk
Proposed by Rodrigo Moya
Status: Merged
Approved by: Tim Cole
Approved revision: 592
Merged at revision: 595
Proposed branch: lp:~rodrigo-moya/ubuntuone-client/dont-connect-when-ready
Merge into: lp:ubuntuone-client
Diff against target: 11 lines (+0/-1)
1 file modified
libsyncdaemon/syncdaemon-daemon.c (+0/-1)
To merge this branch: bzr merge lp:~rodrigo-moya/ubuntuone-client/dont-connect-when-ready
Reviewer Review Type Date Requested Status
Tim Cole (community) Approve
Chad Miller (community) Approve
Review via email: mp+30778@code.launchpad.net

Commit message

Don't make syncdaemon connect in libsyncdaemon when started

Description of the change

Don't make syncdaemon connect in libsyncdaemon when started

To post a comment you must log in.
Revision history for this message
Chad Miller (cmiller) wrote :

I wish the commit message told me more about why.

review: Approve
Revision history for this message
Rodrigo Moya (rodrigo-moya) wrote :

> I wish the commit message told me more about why.

the linked bug has all the information :)

Revision history for this message
Tim Cole (tcole) wrote :

Yes please.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libsyncdaemon/syncdaemon-daemon.c'
2--- libsyncdaemon/syncdaemon-daemon.c 2010-07-20 10:30:05 +0000
3+++ libsyncdaemon/syncdaemon-daemon.c 2010-07-23 13:59:58 +0000
4@@ -369,7 +369,6 @@
5 return_code == DBUS_START_REPLY_ALREADY_RUNNING) {
6 daemon->priv->ready = TRUE;
7 setup_daemon_interface (daemon);
8- syncdaemon_daemon_connect (daemon);
9
10 g_signal_emit (daemon, daemon_signals[READY_SIGNAL], 0);
11 } else

Subscribers

People subscribed via source and target branches