Merge lp:~salgado/launchpad/bug-433991 into lp:launchpad
Proposed by
Guilherme Salgado
Status: | Merged |
---|---|
Approved by: | Brad Crittenden |
Approved revision: | no longer in the source branch. |
Merged at revision: | not available |
Proposed branch: | lp:~salgado/launchpad/bug-433991 |
Merge into: | lp:launchpad |
Diff against target: | None lines |
To merge this branch: | bzr merge lp:~salgado/launchpad/bug-433991 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | release-critical | Approve | |
Henning Eggers (community) | code | Approve | |
Review via email: mp+12170@code.launchpad.net |
To post a comment you must log in.
= Summary =
Make sure zope.i18nmessag eid.message. Message get interpolated when
building a page's title.
== Proposed fix ==
The new fmt:pagetitle formatter iterates over the breadcrumbs and join
their text in a single string, but the leaf breadcrumb may have Message
objects (from the view's .page_title) as their text, so when they're
joined they are not interpolated and we end up with things like 'Ask a
question about ${context}' in the title.
== Tests ==
./bin/test -vvm canonical.launchpad -t test_breadcrumbs
== Demo and Q/A ==
https:/ /answers. launchpad. dev/ubuntu/ +source/ mozilla- firefox/ +addquestion
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: /launchpad/ webapp/ tests/test_ breadcrumbs. py /launchpad/ browser/ launchpad. py
lib/canonical
lib/canonical