`utilities/pgoptions.py` is only used by `database/schema/Makefile`, and
almost all the places where its output is used override the database
name. The only place that doesn't is the code to check whether the
`session_dev` database already exists before creating it.
The database options generated from the `launchpad-admin` config include
`--dbname=launchpad_dev`, and when creating a new set of databases from
scratch and checking whether `session_dev` exists, `launchpad_dev`
doesn't exist yet - so as a result we got `psql: error: FATAL: database
"launchpad_dev" does not exist`, and `session_dev` never got created.
Simply dropping the `--dbname` option from the output fixes this.
This allows us to serve these files from the frontends without hitting
the appservers. I'm not sure why we serve
`lib/canonical/launchpad/images/launchpad.png` here rather than
`lib/canonical/launchpad/images/favicon.ico` (and regardless of file
extension, too!), but this is what we currently do on production so I
thought it best to start by matching the existing setup.
I think in practice most browsers will prefer the icons declared in HTML
via `lib/lp/app/templates/base-layout.pt`, but it doesn't hurt to serve
these files too.
