Merge lp:~serge-hallyn/auto-upgrade-testing/uvtool into lp:~auto-upgrade-testing-dev/auto-upgrade-testing/trunk
Status: | Needs review |
---|---|
Proposed branch: | lp:~serge-hallyn/auto-upgrade-testing/uvtool |
Merge into: | lp:~auto-upgrade-testing-dev/auto-upgrade-testing/trunk |
Diff against target: |
472 lines (+117/-226) 5 files modified
AutoUpgradeTester/UpgradeTestBackendQemu.py (+103/-219) debian/changelog (+7/-0) debian/control (+1/-1) share/profiles/user-data-script (+5/-0) share/scripts/jeos-create-base-image (+1/-6) |
To merge this branch: | bzr merge lp:~serge-hallyn/auto-upgrade-testing/uvtool |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jean-Baptiste Lallement | Needs Fixing | ||
Review via email: mp+207350@code.launchpad.net |
Description of the change
Convert from using vmbuilder and manual qemu commands,
to using uvtool, which uses libvirt to manage vms and
cloud-images as base.
Unmerged revisions
- 103. By Serge Hallyn
-
fix typo pointed out by jibel - remove quotes from "self.name"
- 102. By Serge Hallyn
-
use profilename as vm name
- 101. By Serge Hallyn
-
implement snapshotting
- 100. By Serge Hallyn
-
remove 30 second sleep, and always wait 5 seconds before uvt-kvm wait.
- 99. By Serge Hallyn
-
updates (addressing rharper's feedback):
1. use --disk option to uvt-kvm create to set disk size
2. remove debug statements
3. add --unsafe-caching to arguments
4. comment that the snapshot functions are not implemented.
I don't know whether they are used or not - if not they
should indeed be dropped, else they should be implemented
using virsh.
5. replace the 'while True: self._runInImage(["/bin/ true']) loop
with uvt-kvm wait
6. remove remaining 'sudo's in commands (leftover from earlier
attempt) - 98. By Serge Hallyn
-
Switch from using vm-builder and manual qemu command-lines to using
the libvirt and ubuntu-cloud-image based uvtool. (LP: #1261416)With this patch I was able to do a full run of
./bin/auto-upgrade- tester share/profiles/ server . It ended with: =======
======= ======= ======= ======= ======= ======= ======= ======= =======
FAIL: test_dpkgdist (__main__.TestConfFiles )
Check for existence of *.dpkg-dist files
-------------- ------- ------- ------- ------- ------- ------- ------- -------
Traceback (most recent call last):
File "/tmp/test_conffiles. py", line 76, in test_dpkgdist
self.assertEqual(dpkgdist_ files, [])
AssertionError: Lists differ: ['/etc/default/ rcS.dpkg- dist'] != [] First list contains 1 additional elements.
First extra element 0:
/etc/default/rcS.dpkg- dist - ['/etc/
default/ rcS.dpkg- dist']
+ []which could have been a legitimate test result, or, (just as likely)
the result of something I did not convert correctly.
I've addressed some feedback from rharper and pushed the result.
I still need to implement the snapshotting, then I believe it will be at feature parity.