Merge lp:~sil2100/compiz/raring_revert_3616 into lp:compiz/raring

Might be better to actually look into this than hastily reverting.
Łukasz Zemczak has proposed merging lp:~sil2100/compiz/raring_revert_3616
into lp:compiz/raring.

Commit message:
 Revert revision 3616, as the proposed fix causes serious regressions with
Java Swing applications (LP: #1138517). That's no good!

Requested reviews:
  Compiz Maintainers (compiz-team)

For more details, see:
https://code.launchpad.net/~sil2100/compiz/raring_revert_3616/+merge/151897

- Problem:

The fix introduced in 3616 (fix for LP: #1110138) introduces a serious
regression LP: #1138517.

- Fix:

Let's revert the fix for now, as it's better to have the earlier state than
broken Java Swing applications.

- Tests:

N/A
--
https://code.launchpad.net/~sil2100/compiz/raring_revert_3616/+merge/151897
Your team Compiz Maintainers is requested to review the proposed merge of
lp:~sil2100/compiz/raring_revert_3616 into lp:compiz/raring.

=== modified file 'plugins/decor/src/decor.cpp'
--- plugins/decor/src/decor.cpp 2013-02-26 01:08:15 +0000
+++ plugins/decor/src/decor.cpp 2013-03-06 09:20:28 +0000
@@ -2418,14 +2418,7 @@
            {
                w = screen->findWindow (event->xclient.window);
                if (w)
- {
- DecorWindow *dw = DecorWindow::get (w);
-
- /* Set the frameExtentsRequested flag so that we know to
- * at least update _NET_WM_FRAME_EXTENTS (LP: #1110138)
*/
- dw->frameExtentsRequested = true;
- dw->update (true);
- }
+ DecorWindow::get (w)->update (true);
            }

            mCommunicator.handleClientMessage (event->xclient);

Sam, you are free to have a look at it if you have time for it. It seems the regression is worse than the fix, so let's get that roll in :)

You couldn't wait the ten minutes it takes for me to get home?
On 06/03/2013 5:36 PM, "Didier Roche" <email address hidden> wrote:

> Review: Approve
>
> Sam, you are free to have a look at it if you have time for it. It seems
> the regression is worse than the fix, so let's get that roll in :)
> --
> https://code.launchpad.net/~sil2100/compiz/raring_revert_3616/+merge/151897
> Your team Compiz Maintainers is subscribed to branch lp:compiz/raring.
>

Sorry about that Sam, not sure if we can stop the merge from going in now anyway. The good thing is that the original change was rather small, so I hope re-introducing it, along with the proper fix, will not be that much troublesome. Well, now at least we're 'safe' in case we're not able to come up with a root-cause fix till the end of the day...

I suppose that's true. I'll have a quick look now.

On Wed, Mar 6, 2013 at 5:47 PM, Łukasz Zemczak
<email address hidden> wrote:
> Sorry about that Sam, not sure if we can stop the merge from going in now anyway. The good thing is that the original change was rather small, so I hope re-introducing it, along with the proper fix, will not be that much troublesome. Well, now at least we're 'safe' in case we're not able to come up with a root-cause fix till the end of the day...
> --
> https://code.launchpad.net/~sil2100/compiz/raring_revert_3616/+merge/151897
> Your team Compiz Maintainers is subscribed to branch lp:compiz/raring.

--
Sam Spilsbury