Merge lp:~sinzui/launchpad/delete-conjoined-bugtask-1 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 11356 | ||||
Proposed branch: | lp:~sinzui/launchpad/delete-conjoined-bugtask-1 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
24 lines (+2/-1) 2 files modified
lib/lp/registry/browser/__init__.py (+1/-1) lib/lp/registry/browser/tests/test_milestone.py (+1/-0) |
||||
To merge this branch: | bzr merge lp:~sinzui/launchpad/delete-conjoined-bugtask-1 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Guilherme Salgado (community) | code | Approve | |
Review via email: mp+32796@code.launchpad.net |
Description of the change
This is my branch to correct deletion of bugtasks during milestone deletion.
lp:~sinzui/launchpad/delete-conjoined-bugtask-1
Diff size: 25
Launchpad bug:
https:/
Test command: ./bin/test -vv -t TestMilestoneDe
Pre-
Target release: 10.09
correct deletion of bugtasks during milestone deletion
-------
The fix to permit users to delete milestones with conjoined bugs is bad.
The slave was deleted in my QA on edge, but we wanted to delete the master.
ie. https:/
without a slave. The master is targeted to a series, which make no sense since
there is no bug in the project. This may require SQL to fix.
This bad chunk:
if bugtask.
Rules
-----
* Correct the line of code.
if bugtask.
* Revise the test to verify that the productseries has no bugtasks.
QA
--
* Create a milestone you intend to delete on /gdp/trunk
* Target https:/
to the milestone.
* Delete the milestone.
* Verify The trunk bugtask is gone and that you can see the status
of the project bugtask.
Lint
----
Linting changed files:
lib/lp/
lib/lp/
Test
----
* lib/lp/
* Added a test to verify the productseries has 0 bugtasks. There was
1 before I made the code change to make the test pass :(
Implementation
--------------
* lib/lp/
* Revised the problem code the delete the conjoined_master (the series
bugtask).
Looks good to me