Merge lp:~soren/nova/image-tests into lp:~hudson-openstack/nova/trunk
Proposed by
Soren Hansen
Status: | Work in progress |
---|---|
Proposed branch: | lp:~soren/nova/image-tests |
Merge into: | lp:~hudson-openstack/nova/trunk |
Diff against target: |
81 lines (+27/-1) 3 files modified
nova/image/fake.py (+8/-0) nova/image/service.py (+1/-1) nova/tests/test_image.py (+18/-0) |
To merge this branch: | bzr merge lp:~soren/nova/image-tests |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brian Waldon (community) | Approve | ||
Brian Lamar (community) | Needs Fixing | ||
Review via email: mp+73117@code.launchpad.net |
Commit message
Make fake image driver support get() call (with tests)
Description of the change
Make the fake image driver support get() and make it return an empty string for images with no data.
I'm not completely convinced this is what we actually want to happen (the returning an empty string when no blob is present) but as far as I can tell, this is what the Glance backend does as well.
To post a comment you must log in.
Unmerged revisions
- 1439. By Soren Hansen
-
Make fake image driver return an empty string for images with no data. Add a test for this.
- 1438. By Soren Hansen
-
Merge trunk
- 1437. By Soren Hansen
-
pep8
- 1436. By Soren Hansen
-
Merge trunk
- 1435. By Soren Hansen
-
Add a test to make sure we can write image data and read it back again.
- 1434. By Soren Hansen
-
Merge trunk
Can you update the docstring on BaseImageServic e.get? Other than that this looks good to me.