Ibid

Merge lp:~stefanor/ibid/factoid-383286 into lp:~ibid-core/ibid/old-trunk-pack-0.92

  1. factoid-383286
  2. Merge into old-trunk-pack-0.92
Proposed by Stefano Rivera
Status: Merged
Approved by: Jonathan Hitchcock
Approved revision: 663
Merged at revision: 665
Proposed branch: lp:~stefanor/ibid/factoid-383286
Merge into: lp:~ibid-core/ibid/old-trunk-pack-0.92
Diff against target: None lines
To merge this branch: bzr merge lp:~stefanor/ibid/factoid-383286
Reviewer Review Type Date Requested Status
Jonathan Hitchcock Approve
Michael Gorven Approve
Review via email: mp+7033@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Michael Gorven (mgorven) wrote :

 review approve

review: Approve
Revision history for this message
Jonathan Hitchcock (vhata) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ibid/plugins/factoid.py'
2--- ibid/plugins/factoid.py 2009-05-10 10:24:50 +0000
3+++ ibid/plugins/factoid.py 2009-06-03 18:10:49 +0000
4@@ -298,7 +298,8 @@
5 else:
6 query = query.filter(or_(filter_op(filter_on[0], pattern), filter_op(filter_on[1], pattern)))
7
8- matches = query[start:start+limit]
9+ # Pre-evalute the iterable or the if statement will be True in SQLAlchemy 0.4 [Bug #383286]
10+ matches = [match for match in query[start:start+limit]]
11
12 if matches:
13 event.addresponse(u'; '.join(u'%s [%s]' % (unescape_name(fname.name), len(factoid.values)) for factoid, fname in matches))

Subscribers

People subscribed via source and target branches