Merge lp:~stevenk/launchpad/poppy-sftp-test-isolation into lp:launchpad
Proposed by
Steve Kowalik
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Steve Kowalik | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 10954 | ||||
Proposed branch: | lp:~stevenk/launchpad/poppy-sftp-test-isolation | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
12 lines (+2/-0) 1 file modified
lib/lp/poppy/tests/test_poppy.py (+2/-0) |
||||
To merge this branch: | bzr merge lp:~stevenk/launchpad/poppy-sftp-test-isolation | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jelmer Vernooij (community) | code | Approve | |
Review via email: mp+26717@code.launchpad.net |
Description of the change
This branch removes the SSH_AUTH_SOCK environment variable when running the poppy sftp tests, which stops paramiko doing silly things, like asking the locally running ssh-agent to hand over all its keys.
To post a comment you must log in.
Thanks, +1.
It would be nice to see some of this test infrastructure factored out. Ideally paramiko could probably provide some helper functions for this, rather than seeing it duplicated in both Bazaar, Launchpad and possible other paramiko users.