Lolz

Merge lp:~strycore/lolz/trunk into lp:lolz

  1. trunk
  2. Merge into quickly_trunk
Proposed by Mathieu Comandon
Status: Approved
Approved by: Rick Spencer
Approved revision: not available
Proposed branch: lp:~strycore/lolz/trunk
Merge into: lp:lolz
Diff against target: 12 lines (+1/-1)
1 file modified
bin/lolz (+1/-1)
To merge this branch: bzr merge lp:~strycore/lolz/trunk
Reviewer Review Type Date Requested Status
Rick Spencer Pending
Review via email: mp+17654@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Mathieu Comandon (strycore) wrote :

self.calendar.get_date() returns months on a zero based index (0...11)
datetime.date() accepts months between 1 and 12
Thus, the program does not work in January (and is wrong the rest of the time ;) )

Reply
Revision history for this message
Rick Spencer (rick-rickspencer3) wrote :

Thanks for the merge! TBH, I had kind of stopped working on lolz. If you like, I could set you as the main developer.

Reply
Revision history for this message
Mathieu Comandon (strycore) wrote :

yes I'd love that !
This program can be a great tool for learning Quickly and it brings lolz, what else could we ask for?

Reply
Revision history for this message
Rick Spencer (rick-rickspencer3) wrote :

Okay, I set you as maintainer. Hopefully that gives you full rights to
party on the project ;)

Cheers, Rick

On Tue, 2010-01-19 at 15:47 +0000, Mathieu Comandon wrote:
> yes I'd love that !
> This program can be a great tool for learning Quickly and it brings lolz, what else could we ask for?

Reply

Unmerged revisions

35. By Mathieu Comandon <strider@astoria>

Fixed date (gtk.Calendar returns months between 0 and 11)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/lolz'
2--- bin/lolz 2009-09-12 18:11:10 +0000
3+++ bin/lolz 2010-01-19 13:05:23 +0000
4@@ -129,7 +129,7 @@
5 logging.debug('day_selected() called')
6 self.calendar.hide()
7 d = self.calendar.get_date()
8- display_date = datetime.date(d[0],d[1],d[2])
9+ display_date = datetime.date(d[0],d[1]+1,d[2])
10 self.builder.get_object("calendar_button").set_label(display_date.isoformat())
11
12 #clear out the curren set of images

Subscribers

People subscribed via source and target branches

to all changes: