Merge lp:~stub/launchpad/trivial into lp:launchpad
Proposed by
Stuart Bishop
Status: | Rejected | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Rejected by: | William Grant | ||||||||||||
Proposed branch: | lp:~stub/launchpad/trivial | ||||||||||||
Merge into: | lp:launchpad | ||||||||||||
Diff against target: |
224 lines (+80/-19) 5 files modified
lib/lp/services/librarianserver/storage.py (+5/-1) lib/lp/services/librarianserver/swift.py (+64/-5) lib/lp/testing/swift/tests/test_fixture.py (+3/-2) lib/lp_sitecustomize.py (+3/-8) versions.cfg (+5/-3) |
||||||||||||
To merge this branch: | bzr merge lp:~stub/launchpad/trivial | ||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | Disapprove | ||
Review via email: mp+245822@code.launchpad.net |
Description of the change
Update to using python-swiftclient 2.3.1.
We now can call the close() method explicitly, although at first glance this appears to be a noop with the default HTTPConnection implementation. We still hope this fixes leaks though, as the new library also switches to using the requests library.
To post a comment you must log in.
Unmerged revisions
- 10091. By Stuart Bishop
-
Return swift connections to the pool on 404
- 10090. By Stuart Bishop
-
Close potential HTTP connection leaks, working around Bug #1408616
- 10089. By Stuart Bishop
-
requests 2.5.1
- 10088. By Stuart Bishop
-
Swift fixes for swiftclient 2.3.1
- 10087. By Stuart Bishop
-
Fix swift fixture tests
- 10086. By Stuart Bishop
-
python-swiftclient 2.3.1
- 10085. By Stuart Bishop
-
Merge trunk
Updated things so close() is not a noop.