Merge lp:~stub/launchpad/trivial into lp:launchpad
Proposed by
Stuart Bishop
Status: | Merged | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | Stuart Bishop | ||||||||||||
Approved revision: | 9925 | ||||||||||||
Merged at revision: | 11518 | ||||||||||||
Proposed branch: | lp:~stub/launchpad/trivial | ||||||||||||
Merge into: | lp:launchpad | ||||||||||||
Diff against target: |
13 lines (+0/-4) 1 file modified
lib/canonical/launchpad/scripts/oops.py (+0/-4) |
||||||||||||
To merge this branch: | bzr merge lp:~stub/launchpad/trivial | ||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Nelson (community) | code | Approve | |
Review via email: mp+34948@code.launchpad.net |
Commit message
Remove unnecessary assert breaking oops-prune
Description of the change
oops-prune is currently not working as an assert is being triggered.
The assert seems useless except to warn us that the PostgreSQL regular expression could be more efficient, as it is matching rows that our Python code does not mark up as OOPSes. This is fragile and unnecessary.
To post a comment you must log in.