Merge lp:~ted/indicator-session/confused-icon into lp:indicator-session/0.1

Proposed by Ted Gould
Status: Merged
Merged at revision: not available
Proposed branch: lp:~ted/indicator-session/confused-icon
Merge into: lp:indicator-session/0.1
To merge this branch: bzr merge lp:~ted/indicator-session/confused-icon
Reviewer Review Type Date Requested Status
Kenneth Wimer (community) Approve
Martin Pitt Approve
Neil J. Patel (community) Approve
David Siegel (community) Approve
Ken VanDine Pending
Review via email: mp+13027@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

 * Changing the disconnected icon to system-shutdown-panel
 * Adding a fallback icon for system-shutdown-panel that is the same as system-shutdown in our default theme
 * Making it so that the EmpathyAccountManager object isn't allocated unless the status is set so that we see disconnected sometimes if accounts are configured in Telepathy.

Revision history for this message
David Siegel (djsiegel-deactivatedaccount) wrote :

It freaks me out that you use and repeat a string literal in get_icon, but I am not doing code review :)

I have not tested this, but the changes match recent Humanity addition of icon "system-shutdown-panel":
  http://bazaar.launchpad.net/~elementaryart/humanity/Humanity/revision/399

review: Approve
Revision history for this message
Neil J. Patel (njpatel) wrote :

Looks good. Approved.

review: Approve
Revision history for this message
Martin Pitt (pitti) wrote :

Can't really judge r52, but the other commits look good, +1

review: Approve
Revision history for this message
Kenneth Wimer (kwwii) :
review: Approve

Subscribers

People subscribed via source and target branches