biometryd

Merge lp:~thomas-voss/biometryd/add-snapcraft-setup into lp:biometryd

  1. add-snapcraft-setup
  2. Merge into trunk
Proposed by Thomas Voß
Status: Merged
Approved by: Ken VanDine
Approved revision: 30
Merged at revision: 37
Proposed branch: lp:~thomas-voss/biometryd/add-snapcraft-setup
Merge into: lp:biometryd
Diff against target: 55 lines (+51/-0)
1 file modified
snapcraft.yaml (+51/-0)
To merge this branch: bzr merge lp:~thomas-voss/biometryd/add-snapcraft-setup
Reviewer Review Type Date Requested Status
Scott Sweeny (community) Approve
Ubuntu Phablet Team Pending
Review via email: mp+298255@code.launchpad.net

Commit message

Add an initial snapcraft.yaml setup for biometryd.

Description of the change

Add an initial snapcraft.yaml setup for biometryd.

To post a comment you must log in.
Revision history for this message
Thomas Voß (thomas-voss) wrote :

Please note that this is only a first step to enable biometryd in devmode.

Revision history for this message
Scott Sweeny (ssweeny) wrote :

A couple of suggestions inline to get this building with "snapcraft cleanbuild".

Also, I couldn't get the daemon to run once installed. It came back with:

Jun 24 13:47:59 localhost.localdomain systemd[1]: Started Service for snap application biometryd.biometryd.
Jun 24 13:48:00 localhost.localdomain ubuntu-core-launcher[1365]: terminate called after throwing an instance of 'std::invalid_argument'
Jun 24 13:48:00 localhost.localdomain ubuntu-core-launcher[1365]: what(): parse error - unexpected end of input
Jun 24 13:48:00 localhost.localdomain systemd[1]: snap.biometryd.biometryd.service: Main process exited, code=killed, status=6/ABRT

review: Needs Fixing
lp:~thomas-voss/biometryd/add-snapcraft-setup updated
29. By Thomas Voß

Address reviewer comments.

30. By Thomas Voß

[ Thomas Voß ]
* Verify incoming requests. (LP: #1593383)
* Immediately cancel operations instead of enqueuing cancellation.
* Only for landing purposes.
* cmds::Run now tries to make an educated guess for configuring the
  default device.
* Also consider /custom/vendor/biometryd/plugins when scanning for
  plugins.
[ Ken VanDine ]
* Added COPYING file for the LGPL-3 and updated copyright for the
  single file licensed under MIT

Revision history for this message
Scott Sweeny (ssweeny) wrote :

Works as expected now. LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'snapcraft.yaml'
2--- snapcraft.yaml 1970-01-01 00:00:00 +0000
3+++ snapcraft.yaml 2016-06-24 16:56:15 +0000
4@@ -0,0 +1,51 @@
5+name: biometryd
6+version: 0.0.1
7+confinement: devmode
8+summary: biometryd mediates/multiplexes to biometric devices
9+description: biometryd mediates/multiplexes access to biometric devices
10+ biometryd mediates and multiplexes access to biometric devices present
11+ on the system enabling applications and system components to
12+ leverage them for identification and verification of users.
13+
14+apps:
15+ biometryd:
16+ daemon: simple
17+ command: bin/biometryd run
18+ cli:
19+ command: bin/biometryd
20+
21+parts:
22+ biometryd:
23+ plugin: cmake
24+ configflags:
25+ - -DCMAKE_VERBOSE_MAKEFILE=ON
26+ source: .
27+ build-packages:
28+ - build-essential
29+ - cmake
30+ - doxygen
31+ - google-mock
32+ - graphviz
33+ - libapparmor-dev
34+ - libboost-filesystem-dev
35+ - libboost-program-options-dev
36+ - libboost-system-dev
37+ - libboost-test-dev
38+ - libdbus-cpp-dev
39+ - libdbus-1-dev
40+ - libelf-dev
41+ - libgtest-dev
42+ - libprocess-cpp-dev
43+ - libsqlite3-dev
44+ - lsb-release
45+ - pkg-config
46+ - qt5-default
47+ - qtbase5-dev
48+ - qtdeclarative5-dev
49+ - qtdeclarative5-dev-tools
50+ - qtdeclarative5-test-plugin
51+ snap:
52+ - bin/biometryd
53+ - etc/dbus-1/system.d
54+ - lib/
55+ - lib/libbiometryd*

Subscribers

People subscribed via source and target branches