Merge lp:~thumper/launchpad/edit-commit-msg-link into lp:launchpad/db-devel
Proposed by
Tim Penhey
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | not available | ||||
Proposed branch: | lp:~thumper/launchpad/edit-commit-msg-link | ||||
Merge into: | lp:launchpad/db-devel | ||||
Diff against target: |
316 lines (+120/-27) 7 files modified
lib/canonical/launchpad/javascript/code/codereview.js (+66/-3) lib/canonical/widgets/lazrjs.py (+7/-2) lib/lp/app/templates/base-layout-macros.pt (+3/-1) lib/lp/code/browser/branchmergeproposal.py (+5/-5) lib/lp/code/stories/branches/xx-branch-merge-proposals.txt (+4/-3) lib/lp/code/templates/branchmergeproposal-index.pt (+32/-10) lib/lp/code/windmill/tests/test_branch_merge_proposal.py (+3/-3) |
||||
To merge this branch: | bzr merge lp:~thumper/launchpad/edit-commit-msg-link | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Francis J. Lacoste (community) | release-critical | Approve | |
Māris Fogels (community) | js | Approve | |
Michael Hudson-Doyle | Abstain | ||
Martin Albisetti (community) | ui | Approve | |
Guilherme Salgado | Pending | ||
Review via email: mp+15260@code.launchpad.net |
To post a comment you must log in.
Change the UI so it doesn't show an empty commit message in the editor, but instead shows a link.
Hooks into the editor events so it knows to flash green or red when the commit message ends up empty.