Merge lp:~thumper/launchpad/fix-mirror-failure-story into lp:launchpad

Proposed by Tim Penhey
Status: Merged
Approved by: Michael Hudson-Doyle
Approved revision: no longer in the source branch.
Merged at revision: 11242
Proposed branch: lp:~thumper/launchpad/fix-mirror-failure-story
Merge into: lp:launchpad
Diff against target: 23 lines (+0/-16)
1 file modified
lib/lp/code/stories/branches/xx-branch-mirror-failures.txt (+0/-16)
To merge this branch: bzr merge lp:~thumper/launchpad/fix-mirror-failure-story
Reviewer Review Type Date Requested Status
Launchpad code reviewers Pending
Review via email: mp+31010@code.launchpad.net

Commit message

Fix the branch mirror story to not call branch mirror methods on hosted branches.

Description of the change

Simple fix for the mirror failure testing on hosted branches is to remove that hunk of the test.

Part of my pre-work for making startMirror, requestMirror and mirrorComplete blow up with hosted branches.

To post a comment you must log in.
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

wow, deep.

I thoroughly approve of your goal in this.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/code/stories/branches/xx-branch-mirror-failures.txt'
2--- lib/lp/code/stories/branches/xx-branch-mirror-failures.txt 2010-04-23 08:12:35 +0000
3+++ lib/lp/code/stories/branches/xx-branch-mirror-failures.txt 2010-07-27 03:23:31 +0000
4@@ -213,19 +213,3 @@
5 None
6 >>> print find_tag_by_id(browser.contents, 'mirror-of-ssh')
7 None
8-
9-
10-== Hosted branch mirror failure messages ==
11-
12-A hosted branch with an error message does show a mirror-failure.
13-
14- >>> login(ANONYMOUS)
15- >>> hosted_branch = factory.makeAnyBranch()
16- >>> hosted_branch.mirrorFailed('Some weird internal failure.')
17- >>> branch_location = canonical_url(hosted_branch)
18- >>> logout()
19-
20- >>> browser = setupBrowser()
21- >>> browser.open(branch_location)
22- >>> print_browser_tag(browser, 'mirror-failure')
23- Some weird internal failure.