Merge lp:~thumper/launchpad/fix-puller-logging into lp:launchpad

Proposed by Tim Penhey
Status: Merged
Merged at revision: not available
Proposed branch: lp:~thumper/launchpad/fix-puller-logging
Merge into: lp:launchpad
Diff against target: 27 lines
1 file modified
lib/lp/codehosting/puller/scheduler.py (+4/-3)
To merge this branch: bzr merge lp:~thumper/launchpad/fix-puller-logging
Reviewer Review Type Date Requested Status
Jonathan Lange Pending
Review via email: mp+12537@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

Add some logging.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/codehosting/puller/scheduler.py'
2--- lib/lp/codehosting/puller/scheduler.py 2009-07-23 04:17:24 +0000
3+++ lib/lp/codehosting/puller/scheduler.py 2009-09-28 18:00:36 +0000
4@@ -6,12 +6,10 @@
5 __metaclass__ = type
6 __all__ = [
7 'BadMessage',
8- 'BranchStatusClient',
9 'JobScheduler',
10 'LockError',
11 'PullerMaster',
12 'PullerMonitorProtocol',
13- 'TimeoutError',
14 ]
15
16
17@@ -380,7 +378,10 @@
18 'mirrorFailed', self.branch_id, reason)
19
20 def mirrorSucceeded(self, revision_id):
21- self.logger.info('Successfully mirrored to rev %s', revision_id)
22+ self.logger.info(
23+ 'Successfully mirrored branch %d %s to %s to rev %s',
24+ self.branch_id, self.source_url, self.destination_url,
25+ revision_id)
26 return self.branch_puller_endpoint.callRemote(
27 'mirrorComplete', self.branch_id, revision_id)
28