Launchpad itself

Merge lp:~thumper/launchpad/fix-windmill-reply-test into lp:launchpad

  1. fix-windmill-reply-test
  2. Merge into devel
Proposed by Tim Penhey
Status: Merged
Merged at revision: not available
Proposed branch: lp:~thumper/launchpad/fix-windmill-reply-test
Merge into: lp:launchpad
Diff against target: 12 lines (+1/-1)
1 file modified
lib/canonical/launchpad/javascript/lp/comment.js (+1/-1)
To merge this branch: bzr merge lp:~thumper/launchpad/fix-windmill-reply-test
Reviewer Review Type Date Requested Status
Данило Шеган (community) release-critical Approve
Michael Hudson-Doyle Approve
Review via email: mp+16106@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

In the refactoring of the view, the DOM item the javascript was looking for disappeared.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Assuming you've actually run the test locally (I haven't), this looks fine.

review: Approve
Revision history for this message
Tim Penhey (thumper) wrote :

Yes, I have run the tests :)

Revision history for this message
Данило Шеган (danilo) :
review: Approve (release-critical)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/javascript/lp/comment.js'
2--- lib/canonical/launchpad/javascript/lp/comment.js 2009-12-10 02:27:17 +0000
3+++ lib/canonical/launchpad/javascript/lp/comment.js 2009-12-14 00:18:21 +0000
4@@ -314,7 +314,7 @@
5 reply_link.length - '+reply'.length);
6 var object_url = '/api/beta' + root_url;
7 this.activateProgressUI('Loading...');
8- window.scrollTo(0, Y.one('label[for=field.vote]').getY());
9+ window.scrollTo(0, Y.one('#add-comment').getY());
10 this.lp_client.get(object_url, {
11 on: {
12 success: bind(function(comment){