Launchpad itself

Merge lp:~thumper/launchpad/lines-right-aligned into lp:launchpad

  1. lines-right-aligned
  2. Merge into devel
Proposed by Tim Penhey
Status: Merged
Merged at revision: 10144
Proposed branch: lp:~thumper/launchpad/lines-right-aligned
Merge into: lp:launchpad
Diff against target: 12 lines (+1/-1)
1 file modified
lib/lp/code/templates/branchmergeproposal-macros.pt (+1/-1)
To merge this branch: bzr merge lp:~thumper/launchpad/lines-right-aligned
Reviewer Review Type Date Requested Status
Michael Nelson (community) code Approve
Review via email: mp+17109@code.launchpad.net

Commit message

Make the line numbers right aligned on the active reviews page.

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

Make the lines right aligned so they line up numerically.

Revision history for this message
Michael Nelson (michael.nelson) wrote :

As we chatted, it'd be nice if there was a way to define the class for a column and just apply a style for it, something like:

http://htmldog.com/guides/htmladvanced/tables/

but without that, adding a class to each td is only marginally better than the inline style.

Thanks for the fix!

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/code/templates/branchmergeproposal-macros.pt'
2--- lib/lp/code/templates/branchmergeproposal-macros.pt 2009-12-18 21:31:12 +0000
3+++ lib/lp/code/templates/branchmergeproposal-macros.pt 2010-01-10 21:47:16 +0000
4@@ -55,7 +55,7 @@
5 <tal:registrant replace="structure proposal/registrant/fmt:link" />
6 <tal:date replace="proposal/date_review_requested/fmt:displaydate"/>
7 </td>
8- <td>
9+ <td style="text-align: right">
10 <tal:size replace='proposal/preview_diff/diff_lines_count' condition="proposal/preview_diff"/>
11 </td>
12 <td>