Merge lp:~tom-blacknight/docky/emesene into lp:docky

Proposed by ukblacknight
Status: Rejected
Rejected by: Rico Tzschichholz
Proposed branch: lp:~tom-blacknight/docky/emesene
Merge into: lp:docky
Diff against target: 26 lines (+6/-3)
1 file modified
scripts/emesene_control.py (+6/-3)
To merge this branch: bzr merge lp:~tom-blacknight/docky/emesene
Reviewer Review Type Date Requested Status
Rico Tzschichholz Disapprove
Review via email: mp+21232@code.launchpad.net

Description of the change

- Cleaned up code
- Fixed regression (re-added the try..except clause)
- Updated my name in the Copyright

To post a comment you must log in.
Revision history for this message
Rico Tzschichholz (ricotz) :
review: Disapprove

Unmerged revisions

1180. By ukblacknight

Changed my name on the copyright.

1179. By ukblacknight

Helper should now start.

1178. By ukblacknight

Resolved conflicts

1177. By ukblacknight

Cleaned up emesene_control.py

1176. By ukblacknight

helper files added.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'scripts/emesene_control.py' (properties changed: -x to +x)
2--- scripts/emesene_control.py 2010-03-11 09:33:42 +0000
3+++ scripts/emesene_control.py 2010-03-12 11:50:32 +0000
4@@ -1,7 +1,7 @@
5 #!/usr/bin/env python
6
7 #
8-# Copyright (C) 2010 Tom Blacknight, Rico Tzschichholz
9+# Copyright (C) 2010 Tom Cowell, Rico Tzschichholz
10 #
11 # This program is free software: you can redistribute it and/or modify
12 # it under the terms of the GNU General Public License as published by
13@@ -67,8 +67,11 @@
14 self.update_badge()
15
16 def init_emesene_objects(self):
17- obj = self.bus.get_object(emesenebus, emesenepath)
18- self.emesene = dbus.Interface(obj, emeseneiface)
19+ try:
20+ obj = self.bus.get_object(emesenebus, emesenepath)
21+ self.emesene = dbus.Interface(obj, emeseneiface)
22+ except:
23+ print 'Could not find emesene D-Bus.'
24
25 def conversation_updated(self, count):
26 self.update_badge()

Subscribers

People subscribed via source and target branches

to status/vote changes: