lp:~tomdroid-dev/tomdroid/rework-auth-error-handling

Branch merges

Propose for merging

No branches dependent on this one.

Ready for review for merging into lp:~tomdroid-maintainers/tomdroid/main

Tomdroid Maintainers: Pending requested 2012-04-01

Diff: 454 lines (+137/-76)

7 files modified

res/values/strings.xml (+1/-0)
src/org/tomdroid/sync/SyncService.java (+20/-2)
src/org/tomdroid/sync/web/OAuthConnection.java (+30/-42)
src/org/tomdroid/sync/web/SnowySyncService.java (+29/-11)
src/org/tomdroid/sync/web/WebConnection.java (+9/-3)
src/org/tomdroid/ui/PreferencesActivity.java (+31/-18)
src/org/tomdroid/ui/SyncMessageHandler.java (+17/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #766225: Authenticating with U1 gives a "please check the address you entered" error

Low

Won't Fix

Link a bug report

Related blueprints

289. By Olivier Bilodeau on 2012-04-16

don't send an AUTH_SUCCESS if we got exceptions...

unfortunately this still doesn't fix the preference saving issue but is cleaner now

288. By Olivier Bilodeau on 2012-04-16

added parenthesis around exception stuff so diminish user confusion

287. By Olivier Bilodeau on 2012-04-16

errors now sent to proper activity

by sending the exception message to the handler which called the sync methods the error shows on the right activity

286. By Olivier Bilodeau on 2012-04-16

added tasks

I think it's ugly and shouldn't be done this way but I have no idea on how to better do it in a timtely fashion

285. By Olivier Bilodeau on 2012-04-01

OAuth subsystem exception rework

OAuth authentication core is now throwing all throwable exceptions
Callers are now logging and sending to handlers
Handlers are now showing exception short name on the UI (starting with that since we don't know what to expect and don't want something like 'Token plaintext-token was rejected by server' shown on the screen)

284. By Olivier Bilodeau on 2012-03-31

comment

283. By Olivier Bilodeau on 2012-03-31

more logging on note parsing errors from SdCard sync

282. By Olivier Bilodeau on 2012-03-31

merged local divergence from lp:tomdroid

281. By Olivier Bilodeau on 2012-03-31

merged folder-location feature. Fixes lp:837119

Increased log verbosity when an invalid path is given
Added NEWS

280. By Olivier Bilodeau on 2012-03-31

migrated log statement from string concat to format string to embrace our new logging paradigm