Merge lp:~tony-badwolf/quickly/editors into lp:quickly
Proposed by
Tony Byrne
Status: | Rejected |
---|---|
Rejected by: | Didier Roche-Tolomelli |
Proposed branch: | lp:~tony-badwolf/quickly/editors |
Merge into: | lp:quickly |
Diff against target: |
192 lines (+64/-54) 5 files modified
data/templates/ubuntu-application/configure.py (+2/-2) data/templates/ubuntu-application/edit.py (+1/-1) data/templates/ubuntu-application/internal/quicklyutils.py (+0/-39) data/templates/ubuntu-flash-game/internal/quicklyutils.py (+0/-12) quickly/templatetools.py (+61/-0) |
To merge this branch: | bzr merge lp:~tony-badwolf/quickly/editors |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Didier Roche-Tolomelli | Needs Information | ||
Review via email: mp+81383@code.launchpad.net |
To post a comment you must log in.
Unmerged revisions
- 639. By Tony Byrne <email address hidden> <email address hidden>
-
allows different editors for editing project and configuring dependencies
fixes bug 862302 by informative message instead of crashinguse case
export EDITOR=nano
export QUICKLY_EDITOR= geany
quickly edit &
quickly configure dependenciesremoved another bug
read_input() piped stdout which broke subprocess.call([' nano'])
Looks mostly good as well, thanks for your work there as well :)
Just a question on:
179 + editor = get_editor()
in read_input()
The idea was that quickly configure will still run gedit to have an easy editor for configuring that as well, and not nano or vim. Can't we call there get_quickly_ editor( ) as it was before?