Merge ubuntu-cdimage:lp.2063471 into ubuntu-cdimage:main
Proposed by
Steve Langasek
Status: | Merged |
---|---|
Approved by: | Łukasz Zemczak |
Approved revision: | a6e6f40492f5f9a0a413cff6e42814bfee6bf1c7 |
Merged at revision: | a6e6f40492f5f9a0a413cff6e42814bfee6bf1c7 |
Proposed branch: | ubuntu-cdimage:lp.2063471 |
Merge into: | ubuntu-cdimage:main |
Diff against target: |
13 lines (+1/-1) 1 file modified
lib/cdimage/checksums.py (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Łukasz Zemczak | Approve | ||
Review via email: mp+465012@code.launchpad.net |
To post a comment you must log in.
This will work and is certainly not harmful, but I'm a bit against doing such very specific special-casing in the main checksum code. Are we certain that the only cases we will see for netboot are the ones requiring re-packing of the tarball? Looking at the code... it seems so. If you checked that that's the case, then it's a +1. Otherwise, I'd prefer to have a bit more sublime cases - like checking if we *actually* did modify the netboot tarball.