Merge lp:~ursinha/launchpad/add-translation-focus into lp:launchpad/db-devel
Proposed by
Ursula Junque
Status: | Rejected |
---|---|
Rejected by: | Ursula Junque |
Proposed branch: | lp:~ursinha/launchpad/add-translation-focus |
Merge into: | lp:launchpad/db-devel |
Diff against target: |
92 lines (+21/-3) 5 files modified
lib/lp/registry/configure.zcml (+2/-1) lib/lp/registry/interfaces/product.py (+8/-0) lib/lp/registry/model/product.py (+7/-1) lib/lp/registry/stories/webservice/xx-project-registry.txt (+2/-0) lib/lp/translations/browser/product.py (+2/-1) |
To merge this branch: | bzr merge lp:~ursinha/launchpad/add-translation-focus |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Needs Fixing | |
Review via email: mp+15520@code.launchpad.net |
To post a comment you must log in.
Unmerged revisions
- 8746. By Ursula Junque
-
added translation_
focus_link to the product test, now that it has one :) - 8745. By Ursula Junque
-
last one, I swear
- 8744. By Ursula Junque
-
trivial stylistic changes
- 8743. By Ursula Junque
-
removed spaces and reidented
- 8742. By Ursula Junque
-
now it uses the primary translatable from product.
- 8741. By Ursula Junque
-
primary_
translatable should only return translation_focus - that already handles if it's not set - 8740. By Ursula Junque
-
Removing unused property
- 8739. By Ursula Junque
-
Now translations project page shows the translation_focus in case it's defined, if not it shows the development_focus
- 8738. By Ursula Junque
-
Added translation_focus property, changed primary_
translatable so it will consider translation_focus first - 8737. By Ursula Junque
-
Return first translation_focus, then development_focus as primary_
translatable
= Summary =
This branch fixes bug 422056, adding a way to set translation focus of a product, as we can do with distributions.
== Proposed fix ==
Adding a field with all series of a project on its +changetranslators page.
== Implementation details ==
The implementation is simple: I've added the translation_focus field in product model and interface, and changed the primary_ translatable to choose translation_focus if available (and translatable).
== Tests ==
./bin/test -vvt lp.translations.*
./bin/test -vvt lp.registry.*
== Demo and Q/A ==
Preparing: /launchpad. dev/alsa- utils
1) Go to a project page, such as https:/
2) Add another series to the project
A) Choosing non-translatable series as translation focus: /translations. launchpad. dev/alsa- utils /translations. launchpad. dev/alsa- utils/+ changetranslato rs
1) Go to the translations page of the project, https:/
2) As an admin user, you'll see the Change permissions option, choose it: https:/
3) Choose the series you just added, and save it
Result: You should notice the message in the project translations page saying "Launchpad currently recommends translating alsa-utils trunk series", which means that it chose the development focus series because the one chosen as translation focus isn't translatable.
B) Choosing translatable series as translation focus:
1) Add information to the series you added so it becomes translatable
Result: You should notice the message in the project translations page saying "Launchpad currently recommends translating <the series you added>", which means that it chose the translation focus now that it's a translatable series.
C) Choosing no translation focus at all:
1) Choose no series as translation focus
Result: You should notice that it will recommend to translate the development focus.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: registry/ configure. zcml registry/ interfaces/ product. py registry/ stories/ webservice/ xx-project- registry. txt translations/ browser/ product. py registry/ model/product. py
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
== Pylint notices ==
lib/lp/ registry/ interfaces/ product. py fields' (No module named restful) interface' (No module named restful) declarations' (No module named restful) createProduct] Operator not preceded by a space oject=' freshmeat_ project' , wikiurl='wiki_url', ='download_ url', project= 'sourceforge_ project' , lang='programmi ng_lang' ) factory_ operation( eproject' , 'programminglang', reviewed' , 'licenses', 'license_info',
593: [C0301] Line too long (83/78)
34: [F0401] Unable to import 'lazr.enum' (No module named enum)
72: [F0401] Unable to import 'lazr.restful.
73: [F0401] Unable to import 'lazr.restful.
74: [F0401] Unable to import 'lazr.restful.
778: [C0322, IProductSet.
freshmeatpr
^
downloadurl
sourceforge
programming
@export_
IProduct, ['name', 'displayname', 'title', 'summary', 'description',
'project', 'homepageurl', 'screenshotsurl',
'downloadurl', 'freshmeatproject', 'wikiurl',
'sourceforg
'license_
'registra...