lp:~vcs-imports/gimp/+git/gimp

Author: Alx Sa
Author Date: 2024-05-17 14:47:29 UTC

text: Update font property to GimpFront

Resolves #11550
The import code for X Logical Font Description fontnames
was not updated to use GimpFont instead of strings.
This caused crashes when we tried to set GimpFont properties
with gchars. This patch updates the code to create a new
GimpFont object from the font name string.
Additionally, it increases the read length by one, as we were losing
the last character of each field as it was split on the "-" character.

Author: Alx Sa
Author Date: 2024-05-17 00:22:35 UTC

dialogs: Fix resizing issue with layer attributes checkboxes

Resolves #10026

In GTK3, selecting a checkbutton makes the label bold. This
increases the width of label, and if it's the longest item in a
box, this causes minor "twitching" and resizing of the dialogue.
This patch wraps the box in a GtkScrolledWindow to prevent
this.

Author: Bruno Lopes
Author Date: 2024-05-16 13:30:09 UTC

build/windows: Drop hardcoded Intro image from 2.9 (pre-2.10) series

Now, the image is generated from splash image in gimp-data

Author: Bruno Lopes
Author Date: 2024-05-14 14:03:45 UTC

gitlab-ci, build: Make "Cross" scripts compatible with Local builds (part 1)

* Some bashisms were dropped, since local machines can have different shell
* Every env (sh and "cross") command is self-contained in only one script per
  stage (*deps*cross* and *gimp*cross* .sh), as we do in native scripts.

Also, reintroduce pkg caching for crossroad. The possibility of using it is
one in thousands since we don't have distributed cache, but it's better than
rely totally on MSYS2 mirrors, which can be be extremely sick sometimes.

Unfortunately, the final result of my cleanup and compatibility work is limited,
since our (not anymore) "cross" builds depends totally on a Debian build.

Author: Rodrigo Lledó
Author Date: 2024-05-14 15:54:21 UTC

Update Spanish translation

Author: Alx Sa
Author Date: 2024-05-13 17:05:33 UTC

actions: Use Settings rather than Preferences on MacOS

Per Lukas Oberhuber, Preferences should be called Settings
on MacOS, as it was before the GTK3 menu port.

Author: NielsDG
Author Date: 2024-05-09 21:17:12 UTC

plug-ins: Put the same size on metadata tag values

... by using a `GtkSizeGroup` in the metadata viewer.

Author: Alx Sa
Author Date: 2024-05-06 18:38:12 UTC

core: Create GimpExportOptions class

This will be used (in the future) to export
with different options while not impacting
the original image. For now, it's just an
empty placeholder.

Author: Alx Sa
Author Date: 2024-05-07 04:33:44 UTC

plug-ins: Update Darktable API check

Darktable 4.6 updated the version output format to conform
to standards. This broke the regex check that GIMP uses to
test if Darktable is installed. The developers of Darktable
have added a new --gimp flag for us to use for checking
support. This patch updates our check code to use this
API first, then fallback on the original regex code if a
version of Darktable before 4.6 is installed.

Author: Bruno Lopes
Author Date: 2024-03-20 16:40:56 UTC

Use LLDB or GDB on Windows

Author: Bruno Lopes
Author Date: 2024-05-02 18:58:32 UTC

gitlab-ci: non splitted DWARF .debug symbols on Store

WACK rejects the .msix when it have splitted .debug symbols

Author: Bruno Lopes
Author Date: 2024-04-30 23:10:42 UTC

gitlab-ci, build/windows: Make Win crossbuild use the universal variables

This saves a bit of code and avoids disparity between build jobs.

Author: Jehan
Author Date: 2024-04-30 18:55:42 UTC

plug-ins: port file-pdf-load to the new GimpVectorLoadProcedure logic.

Author: Jehan
Author Date: 2024-04-27 13:03:47 UTC

Issue #11385: revert creating/deleting a config dir for every in-build GIMP calls.

While theoretically, commit 2f9881c03fd was better (perfectly fresh
config directory then cleanup at the end of each run of GIMP during the
build), it looks that in practice, it makes the build a lot slower, in
particular on Windows.
I think it might be related to slower file access on Windows (while
creating/deleting files is faster on Linux).

So I'm reverting to how it was before, except that I add a unique
cleanup step (at the start of the build only, just before creating a new
directory) and also, I get slightly better "depends" organization.

Author: Bruno Lopes
Author Date: 2024-01-22 20:53:55 UTC

build/windows: Make Installer versioning vars more neutral

Now, the installer files match the meson config.h naming:
'gimp_version', 'gimp_app_version' and 'gimp_api_version'.
"devel" was replaced by meson 'gimp_unstable' too.

util_version was dropped since it lost its utility.

Author: Bruno Lopes
Author Date: 2024-04-22 10:36:48 UTC

Configure SAST in `.gitlab-ci.yml`, creating this file if it does not already exist

Author: Bruno Lopes
Author Date: 2024-03-26 16:58:06 UTC

app: Fix a bit the debug hell

Our debug dialog has a wording that can be causing many dull reports.
This is partly confirmed in issues when asking "why did you do that?"
The reporter responds: "I just did what GIMP told me: copy-paste".
This lack of clarity is sad. Let's fix it with good psychology:

1. Remove texts that can induce the user to not fill all the data:
   -- "simple" can make the user act like reporting is just fun so misread
   -- "bug information" can make the user think that is the whole reporting
   -- "in a new bug report" can make the user just paste after creating it
2. Unify texts that can make the user get tired and misread all the text:
   ** "Copy the..." + "Open our.." > "Create an..." straight to the point
3. Add texts be more aware of the reporting process
   ++ "Fill in..." to avoid incomplete reports
   ++ "After this..." to avoid pasting without filling
4. Finally, reword the biggest culprit: the "copy-paste" advice

Author: Alx Sa
Author Date: 2024-03-08 11:55:14 UTC

plug-ins: Add tooltip with metadata entry hints

Adds a new struct that allows us to define hints for
entering metadata (such as separating values with
a comma or newline).

Author: Alx Sa
Author Date: 2024-02-02 11:33:00 UTC

tools: Add option for destructive filters

Adds a checkbox in the Filter tool so that
users can choose to apply a filter
destructively or non-destructively.
Currently only layers can have NDE effects
so it's not shown for masks and other
drawables.

Author: Bruno Lopes
Author Date: 2024-03-26 11:58:49 UTC

My fixes

Author: Alx Sa
Author Date: 2023-06-18 20:10:10 UTC

widgets: Update image display on imageview select

In the Image Dockable, clicking on an image will update the layers and
navigation views. However, the actual canvas image will not update
unless you double-click the item.
This adds a select_item function so the canvas is updated on a single
click as well.

Author: Mike006
Author Date: 2023-10-11 01:56:29 UTC

app: Save maximize state of image window in...

...multi-window-mode too.

Author: Alx Sa
Author Date: 2024-01-13 23:47:58 UTC

core: Add alpha to layer for transparency masks

Adding a mask using the layer's alpha channel has inconsistent behavior
depending on whether the layer actually has an alpha channel.
This patch adds an alpha channel to the layer if either the alpha channel
or transfer alpha channel masks are intentionally selected by the user.

Author: Jacob Boerema
Author Date: 2024-03-16 19:11:19 UTC

WIP Issue #8453

Rewritten layer parser to detect all clipping groups

Author: Bruno Lopes
Author Date: 2024-03-15 21:51:48 UTC

Issue #811: Make each language a component for the Installer

Author: Alx Sa
Author Date: 2024-03-09 03:18:46 UTC

Updating code after 2.99.18 changes

Author: Alx Sa
Author Date: 2024-02-25 14:34:15 UTC

widgets, themes: Fix bug with selection...

background color. Resolves #9983.

We now check the parent widget's color
first to prevent issues with the selection
altering the background color of the
icon until the view is refreshed.
As a result, we can now define the
selected color of an icon, fixing a
regression from 2.10.

Author: Alx Sa
Author Date: 2023-06-12 22:12:55 UTC

actions: Add multiple selected layers to group

This changes the current behavior of creating one new layer group per
selected layer. Instead, 2+ selected layers are combined in one new
layer group. The behavior for one selected layer/group is unchanged.

Author: Andre Klapper
Author Date: 2024-02-21 15:02:03 UTC

Fix GCC 14 documentation warnings in libgimpbase/gimpchoice.c

Closes #10904

Author: Alx Sa
Author Date: 2023-09-21 05:30:48 UTC

widgets: Restore GTK2 tab scrolling behavior

In GTK2 and GIMP 2.10, you can use the mouse scroller to
switch between dockable tabs if you hover over the bar.
This behavior was removed from GtkNotebook in GTK3.
This patch follows other GTK3 applications in re-implementing
the behavior with a scroll-event callback.

Author: =?utf-8?b?w5h5dmluZCBLb2zDpXM=?=
Author Date: 2024-02-17 23:20:03 UTC

app: increase color precision in indexed conversion

The indexed conversion code was originally written for very low-memory systems,
this makes the mapping it does quantized and noisy, for examples see issue
 #5159 this commit removes quality/memory use trade-offs, modern machines can
take a 2-300mb temporary table allocation.

Author: =?utf-8?b?w5h5dmluZCBLb2zDpXM=?=
Author Date: 2024-02-09 16:08:34 UTC

app/gegl: avoid double registration of format with newer babl

Author: Jehan
Author Date: 2024-02-07 16:13:16 UTC

app, pdb: "Add Layer Mask" dialog asks whether to edit mask immediately.

While there are cases when you want to edit the mask straight away (this is
often the case when starting with a white or black mask), in many other cases,
the mask may be already as you want it per its initialization (e.g. when
initializing with a channel, selection, the alpha channel, etc.).

Until now, the Add Mask dialog was always switching to the "Edit Layer Mask"
mode by default, which forced an additional unneeded click each time you created
a mask (and were in a case where you initialize the mask as you want it
directly).

Now adding "Edit mask immediately" feature in the "Add Layer Mask dialog":

* It's checked by default to keep historical behavior.
* As most other dialogs, the last value is remembered, allowing people with
  repetitive workflow not to have to repeatedly set the settings each and every
  time.
* This default is also visible and settable in Preferences > Interface > Dialog
  Defaults.

Author: Alx Sa
Author Date: 2024-02-06 13:28:40 UTC

tools: Add NDE option for Gradient tool

This adds a new toggle that lets the user
choose to apply a gradient as a
non-destructive filter (off by default)

Author: Alx Sa
Author Date: 2023-07-13 22:05:19 UTC

actions: Add "Save Window Positions" menu

This adds the "Save Window Positions Now" option from Preferences to the
Windows menu.

Author: Alx Sa
Author Date: 2024-02-01 03:00:29 UTC

paint: Use filters when cloning if applicable

The Clone Tool now has a new option to include or ignore filters
when setting a source. If disabled (and Sample Merged is not set),
the raw pixel buffer will be used as source rather than with
any active non-destructive filters applied.

Author: Bruno Lopes
Author Date: 2023-12-05 19:08:56 UTC

app, devel-docs: update Microsoft Store documentation

(cherry picked from commit d515406f1e184f53ba6d076a390170009099567d)

Author: Alx Sa
Author Date: 2022-11-19 18:07:10 UTC

text: Add additional outline options

This creates a new "outline direction" property, that determines whether
the outline grows outward, inward, or centered from the text.

Author: Jacob Boerema
Author Date: 2023-11-19 21:40:12 UTC

plug-ins: unfinished dicom improvements

Adding support for Window Width, rescaling etc.

Author: Alx Sa
Author Date: 2023-11-09 12:29:01 UTC

widgets: Remove raise/lower buttons on dockable

Suggested by @prokoudine, the main purpose of these buttons has been replaced by
multi-select, drag and drop, and layer groups.
Removing this allows the layer dialogue to be shrunk further as needed.

Author: Mehdi Chinoune
Author Date: 2023-10-18 12:39:23 UTC

build: Use MSYS2/UCRT64 instead of MSYS2/MINGW64

MSYS2 now recommends using UCRT64.

Author: Alx Sa
Author Date: 2023-10-25 17:45:04 UTC

widgets: Fix multi-select bug caused by 3e101922

(Diagnosed by @Jehan)
The call to gtk_tree_view_set_cursor () causes the selection to revert to
single selection mode; this prevents users from multi-selecting options
in lists that support it.
To fix this while preventing the original bug fixed in 3e101922, the call to
gtk_widget_grab_focus () is made via g_signal_connect_after ().

Author: Alx Sa
Author Date: 2023-10-24 11:05:15 UTC

tools: Fix generated brush angle

Per documentation, generated brushes should
be drawn counter-clockwise from their angle.
This patch adjusts the paint and outline accordingly.

Author: Mehdi Chinoune
Author Date: 2023-10-15 20:06:34 UTC

build: Use MSYS2/UCRT64 instead of MSYS2/MINGW64

MSYS2 now recommends using UCRT64.

Author: Alx Sa
Author Date: 2023-06-24 15:00:13 UTC

dialogs: Disable conversion if profile mismatched

If the profile color model does not match the image's,
or what you plan to convert the image to, the OK button
is disabled.
A warning is also shown to inform the user why.

Author: Alx Sa
Author Date: 2023-09-30 02:15:15 UTC

display: Close image tabs with middle mouse button

This adds a "button-press-event" to the ImageWindow's
image tabs. If the user has clicked with the middle mouse button,
it calls the same close code as if they had clicked on the "X"
button.

Author: Jacob Boerema
Author Date: 2022-12-31 16:51:41 UTC

WIP adding ability to handle PSD text layers

So far only most of the reading of the PSD data related to text handling
is done.
We still need to convert relevant parts to markup text that GIMP can
handle. To do that, we probably need to store all keys and values we
read, and then when converting to markup check all keys that we can
use for their values.

Author: Alx Sa
Author Date: 2023-09-18 10:50:04 UTC

widgets: Show layer/path name for active selection

If a single path or layer name is selected,
show it in the "multi-selection" bar in the dockable.

Author: Jehan
Author Date: 2023-09-07 16:14:13 UTC

plug-ins: new JPEG export option to value file size over encoding speed.

This uses MozJPEG from Mozilla and is dependent on this patch to be merged:
https://github.com/mozilla/mozjpeg/pull/383
This is an optional option (standard libjpeg API, e.g. with jpeg-turbo, is still
used when MozJPEG is not detected at build time).

When using MozJPEG, we have access to both the standard algorithm used by
libjpeg-turbo, since MozJPEG is a patched version of libjpeg-turbo, and their
own encoding algorithm. We can switch from one to another with a single call.

Here is what the maintainer says about MozJPEG goal:

> The point of MozJPEG is to improve quality/filesize ratio. It's a win-win: you
> get better quality for the same file size, or better file size for the same
> quality, or both. There is no downside in either quality or file size. MozJPEG
> tunes for these two aspects over speed. libjpeg-turbo's maintainer values speed
> over the other two variables.
>
> MozJPEG has a few techniques. Improved splitting of progressive scans gives
> smaller file size while being 100% visually identical with libjpeg-turbo.
>
> But MozJPEG also has trellis quantization and tuned quantization tables that
> give better visual quality, but on a microscopic scale they make different
> choices than libjpeg-turbo, so some pixels differ. The differences are
> relatively small and predictable, so there's no risk of unexpectedly ruining
> an image (especially that on average, you get better quality).

Cf. https://github.com/mozilla/mozjpeg/issues/382#issuecomment-730544796

Note that after several testing, I could indeed confirm that it seems to always
produce smaller files (as far as my testing went) for similarly looking quality,
but the speed cost can actually be quite important: on my computer, for some
random files where encoding would take 0.7 second, it took 3.5 secs with
mozjpeg; for much bigger file (~25MiB) where export with jpeg-turbo takes about
3.9 secs, it takes 30+ seconds with MozJPEG which is a huge difference and can
be very frustrating.
For small files only, this is less of a problem (I still timed an important
difference, but from 0.05 to 0.15 secs is actually bearable).

This is why this cannot be an option checked by default.

About naming: I hesitated to call it "Export for Web" because it's clearly one
of the big use cases (optimizing file size for images on websites), but I just
decided to go with a much more explicit name (even though it may resonate less
that the basic "Export for Web" which everyone asks for).

Author: Alx Sa
Author Date: 2023-06-28 10:21:25 UTC

actions: Indicate if image is dirty in Windows menu

Partially resolves #9520
Adds an asterisk to the image listing just like in the title bar, if the
image has unsaved changes.

Author: Alx Sa
Author Date: 2023-08-13 18:16:17 UTC

menu: Add option to change transparency type in View menu

This allows quicker access rather than repeatedly going to the Preferences dialogue.

Author: Alx Sa
Author Date: 2023-08-09 02:43:03 UTC

config: Add options to auto-scale imported layers

If enabled in Preferences, any image that's
dragged into an existing canvas (or
explicitly opened as a layer) will be scaled
to fit the current canvas size.

Author: Alx Sa
Author Date: 2023-08-04 13:41:44 UTC

Add pressure gain control

Author: Jacob Boerema
Author Date: 2023-08-02 19:52:39 UTC

libgimpwidgets: remove deprecated warning for gtk_icon_theme_add_builtin_icon

gtk_icon_theme_add_builtin_icon has been deprecated since GTK 3.14,
it recommends replacing with: gtk_icon_theme_add_resource_path.

After testing, it seems our gimp-wilber-eek icon works even without
using this replacement. So, we just remove all code that explicitly
sets our gimp-wilber-eek icon.

Author: Alx Sa
Author Date: 2023-06-20 01:54:56 UTC

tools: Close iscissors curve on pressing Enter

This better aligns the tool with the path tool, which also closes on
Enter if it is not already a connected path.

Author: Alx Sa
Author Date: 2023-07-14 13:38:05 UTC

plug-ins: Warn about no transparency in JPEGs

This adds a warning label to the JPEG export dialogue if the layer contains
transparency, to indicate another format should be used.

Author: NielsDG
Author Date: 2023-05-25 11:54:02 UTC

themes: Add option to follow system color scheme

Now that the XDG Settings portal has started exposing a "color-scheme"
property in the latest versions, we can follow this property and switch
from dark to light theme (or vice versa) with the rest of the system.

Author: Alx Sa
Author Date: 2023-07-02 14:58:18 UTC

plug-ins: Allow export of 32bpp SunRas image

Per specifications (such as they are), 32bpp SunRas files left-pad 0x00 to 24bpp images.
A toggle is added to let users choose which format to save in for RGB images.
Note that some image editors treat this value as transparency.

Author: Alx Sa
Author Date: 2023-06-28 01:29:07 UTC

core: File -> New... Image has alpha by default

This aligns with how new layers have alpha by default.

Author: Alx Sa
Author Date: 2023-06-24 17:44:17 UTC

scripts: Check if layer is floating selection

Since cutting/pasting does not always produce a floating selection
anymore, gimp-floating-sel-anchor is now conditionally run in the
pasteat function.

Author: Alx Sa
Author Date: 2023-03-08 00:37:07 UTC

display: Connect path on click in design mode

Rather than having to hold Ctrl to switch to edit mode, users can now
just click the start point from the end node to create a connected path.

Author: Alx Sa
Author Date: 2023-06-14 03:45:31 UTC

widgets: Allow all layers to be deselected

Currently, GimpImage's selected layers are only updated if at least one
is still selected. However, it is possible to deselect all layers by
holding Ctrl when clicking.
This patch updates GimpItemTreeView to notify GimpImage
when all layers have been deselected.
Per Jehan, the image is also set to NULL before the container
is switched so that we don't deselect all image layers when swapping
images.

Author: Alx Sa
Author Date: 2023-05-28 20:38:58 UTC

scripts: Add script create center guides

Automatically creates a vertical and horizontal center guide for an
image.

Author: Alx Sa
Author Date: 2023-06-01 02:48:02 UTC

dialogs: Add Preferred CMYK option to...

...soft-proofing profile menu.
If the user has set a Preferred CMYK profile in preferences, it will
be added as the second option in the combo box.

Author: Jacob Boerema
Author Date: 2023-05-27 21:20:12 UTC

libgimpbase: improve parasite API documentation

Author: Jacob Boerema
Author Date: 2023-03-29 20:36:30 UTC

app, libgimp, pdb: use 64-bit window id

This is a follow-up of the clang issues signaled in #8649. When testing
CLANG64 on Windows under MSYS2, there was another similar issue in
gimpwidgets-utils.c.
In addition to that, the previous cast using GPOINTER_TO_INT proved
incorrect, since that discards anything except the lower 32-bits.
Since we already return guint64 here, we will cast this to guint64 too.

By changing the return to guint64 in gimpwidgets-utils.c too, we kind of
snowball into needing to change multiple functions that so far used
guint32 for window ids.

Author: NielsDG
Author Date: 2023-05-24 10:34:32 UTC

app: Stop using grabs in GimpDisplayShell

We don't need them and they're giving us deprecation warnings anyway, so
just remove them completely.

Author: NielsDG
Author Date: 2022-06-12 08:11:28 UTC

WIP

Author: Michael Schumacher
Author Date: 2021-02-27 16:52:45 UTC

app: use "Export Image As" for the "Export As..." dialog title

This addresses the inconsistency mentioned in merge request !415 for issue #4021. The API change is localized,
there seem to be no uses of file_export_dialog_show() outside of file-commands.c.

Export uses "Export Image", so I opted for "Export Image As" for consistency.

Author: Jehan
Author Date: 2023-04-22 19:44:22 UTC

desktop, etc: remove more Makefile.am.

There are just some comment which I moved in the desktop's meson file for a few
pieces where we might want explanations or improvements later.

Author: Jacob Boerema
Author Date: 2023-03-26 21:48:28 UTC

app: enable previously disabled tests to see if they still fail

Author: Michael Schumacher
Author Date: 2023-03-19 23:22:21 UTC

flatpak: Use tee to have output shown in gitlab jobs and also go to the specified log file.

Author: Michael Schumacher
Author Date: 2023-03-07 20:00:24 UTC

app: regenerated pdb

Author: Alx Sa
Author Date: 2023-03-14 03:41:58 UTC

display: Add color option to guides

This adds a new color property so that users can optional define it.
Only the script-fu dialogues currently provide this option;
all non-dialogue methods to create guides use the default color to
prevent disrupting workflows.

Author: Michael Schumacher
Author Date: 2023-01-26 01:44:00 UTC

Docker security check runs in test stage

Author: Jehan
Author Date: 2020-07-29 17:17:04 UTC

WIP.

Author: Jehan
Author Date: 2022-09-10 21:56:56 UTC

Issue #8518: Could not close new Welcome dialog.

I can't reproduce this on Linux and according to docs and tests, the
"response" signal handles the delete-event.
But maybe there is a bug on macOS where it is not triggered when
clicking the window button?

THIS IS A TEST COMMIT, DO NOT PUSH AS-IS!

Author: Jehan
Author Date: 2022-08-22 21:04:44 UTC

Revert "configure.ac, meson.build: post-release version bump to 2.99.13."

This reverts commit ba83b30c2174972be035f985ea7cd7603c38bd21.

Author: NielsDG
Author Date: 2022-06-10 08:21:46 UTC

pdbgen

Author: NielsDG
Author Date: 2020-05-16 13:34:31 UTC

Add a Bash completion file

Author: Jehan
Author Date: 2022-03-25 09:48:51 UTC

build: building with exactly babl 0.1.92 and GEGL 0.4.36 for revision 2.

We could just use the HEAD of these branch as we did until now for
development versions of GIMP, but I guess that using exact release
versions might be better, even for our dev releases.

Author: Jacob Boerema
Author Date: 2021-07-13 21:27:06 UTC

Change: Allow loading of indexed images with linear precision.

This fixes #6886 where certain indexed png images fail to load.

As far as I can see babl supports loading of indexed linear precision
images, so lets change the checks that prohibited loading of these images.

Also add a console error when precision is not U8 for GIMP_INDEXED.

Author: =?utf-8?q?Bart=C5=82omiej_Piotrowski?=
Author Date: 2022-03-12 20:03:21 UTC

Trigger a new build

Author: NielsDG
Author Date: 2021-12-19 17:09:28 UTC

WIP

Author: Jacob Boerema
Author Date: 2021-08-30 23:25:02 UTC

Vector Layers from GSoC 2006 by Hendrik Boom

Adaption of patch 1 from issue #282.
Author according to patch: Martin Nordholts <martinn@src.gnome.org>

A whole lot of changes needed to be made to make it build on master.
Several assumptions have been made, parts have been disabled, just
to make it compile - Wormnest.

January 2022:
There's a large #if 0 part in app/tools/gimpvectortool.c. I think most of
that code was already integrated into GIMP in app/display/gimptoolpath.c,
but I didn't get around to checking if that is true for all of it.

Author: NielsDG
Author Date: 2021-12-31 12:52:54 UTC

devel-docs: Render GIMP3 porting guide in gi-docgen

Use gi-docgen's support of Markdown to actually render our plug-ins and
script-fu porting guide. This has a few cool advantages:

* We get free HTML rendering, which is especially useful once we start
  publishing our documentation online.
* We can actually use gi-docgen syntax to link to the appropriate
  functions/methods/etc so people who are porting can just click those
  links.

Author: Jehan
Author Date: 2021-11-12 17:18:47 UTC

Fixes:

$ sudo installer -pkg python-3.9.7-macosx11.pkg -target /
sudo: a terminal is required to read the password; either use the -S option to read from standard input or configure an askpass helper

Don't we run as root by default anyway?

Author: Jacob Boerema
Author Date: 2021-09-30 17:14:14 UTC

WIP build: try to fix meson on Windows

Author: Stanislav Grinkov
Author Date: 2021-09-28 18:30:25 UTC

build, meson: Fix rc files build order dependency...

by adding special filler custom_target() build rules.

Basically, these build rules do nothing (a mere meson --version call),
but they ensure that `git-version.h` is built first, before the dependant
rc files are used in respective resource compiler build targets.

This still a nasty trick (not a proper solution), but it do the job.

See #6257 for additional information.

Author: Jacob Boerema
Author Date: 2021-08-03 20:34:38 UTC

build: check to see if this fixes ci meson build failure

Author: Jehan
Author Date: 2021-03-23 15:05:36 UTC

Just a small test for @DesMcGuinness to test.

Author: Michael Schumacher
Author Date: 2021-07-07 16:11:22 UTC

Configure SAST in `.gitlab-ci.yml`, creating this file if it does not already exist

Author: Jehan
Author Date: 2021-05-27 09:45:32 UTC

build: sync with development flatpak.

- dri access needed (cf. commit de8be943 on our Flathub repo).
- GNOME runtime still only provides lcms 2.10 (even in its master build)
  and we ned version 2.12 to avoid some crashes (cf. commit ae60863e
  from our flathub repo).

Author: Michael Schumacher
Author Date: 2021-04-29 20:30:13 UTC

Set .gitlab-ci.yml to enable or configure SAST

Author: Simon McVittie
Author Date: 2021-04-07 16:38:27 UTC

qbist: Allocate path dynamically instead of using a PATH_MAX-sized buffer

On modern Unix systems, PATH_MAX is more of a guideline than an actual
limit. In particular, Linux arbitrarily defines PATH_MAX as 4096 but
can actually have paths longer than this, and on Hurd the macro isn't
defined at all.

This turns out to be the only place in GIMP 2.10.x where PATH_MAX is
used outside #ifdef ENABLE_RELOCATABLE_RESOURCES.

Loosely based on commit d659bb12, but without using new API.

Bug-Debian: https://bugs.debian.org/934077
Signed-off-by: Simon McVittie <smcv@debian.org>

Author: Jehan
Author Date: 2021-03-22 21:28:05 UTC

app: do not use PATH_MAX and realpath() on macOS.

See the comments in MR!424.
Basically realpath relies on false assumptions (probably ones which used
to be true when the API got created) on the max size of a path. Actually
nowadays paths can be much bigger than what the macro advertizes or can
even be unbounded.
The Linux version of realpath() allows the second parameter to be NULL,
in which case it would allocate the buffer, exactly for this reason
(written in the BUGS section on the man). Unfortunately this behavior is
not standardized in POSIX and the man from Apple I found does not
indicate it will do this.

So let's use g_canonicalize_filename() instead, which seems to do the
right thing. Similarly use g_strdup_printf instead of g_snprintf().

Author: Jehan
Author Date: 2021-03-03 12:23:28 UTC

gitlab-ci: testing gtk!1563 for Windows Ink support.

Properly this time (hopefully).

Author: Michael Schumacher
Author Date: 2021-02-26 10:52:30 UTC

app: use "Save Image As" for the "Save As..." dialog title

Save uses "Save Image", so I opted for "Save Image As" for consistency.

This introduces an inconsistency with the Export and Export As... dialogs where "Export Image" remains in use
for both, but addressing that will require an API change for file_export_dialog_show()

Fixes issue #4021.

Author: Michael Schumacher
Author Date: 2021-02-13 22:27:40 UTC

gitlab-ci: add XDG_DATA_DIR/lib to LD_LIBRARY_PATH

Author: Jehan
Author Date: 2021-02-13 16:34:48 UTC

Issue #6435: Off canvas guides.

Allow guides with off-canvas position since we can now view and work
outside the canvas.

The guide deletion interaction does not change too much, except you
don't delete a guide because it's dropped off-canvas but off the display
viewport area instead.

The XCF format is technically unchanged as PROP_GUIDES was already
expecting an int32 coordinate (with max value at GIMP_MAX_IMAGE_SIZE,
way below uint32 max anyway). Yet our code and XCF docs was explicitly
asking to ignore negative coordinate guides, which makes a change in
behavior for the XCF parser, hence a new version XCF 15. Loading will
still ignore negative position guides (even also bigger than image
dimension guides now) for XCF 14 and below, but will now accept any
position for XCF 15 and above.